Anoke/frostfs-node
1
0
Fork 0
forked from TrueCloudLab/frostfs-node
Code Pull requests Activity

[#493] node/config: Fix corrupting of path to the subsection

Browse source 
In previous implementation `Config.Sub` method could lead to the violation
of the internal `path` slice because of `append`. This has been observed on
deeply nested subsections.

Fix `Config.Sub` to copy internal slice in order to prevent violations.
Cover problem case in test config files and unit test.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
This commit is contained in:
Leonard Lyubich 2021-06-01 20:12:00 +03:00 • committed by Leonard Lyubich
parent 72d81dba92
commit e26dc0a6e3
4 changed files with 46 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

18
cmd/neofs-node/config/calls_test.go
View file

@ -42,3 +42,21 @@ func TestConfigEnv(t *testing.T) {
require.Equal(t, value, c.Sub(section).Value(name))
}
func TestConfig_SubValue(t *testing.T) {
configtest.ForEachFileType("test/config", func(c *config.Config) {
c = c.
Sub("section").
Sub("sub").
Sub("sub")
// get subsection 1
sub := c.Sub("sub1")
// get subsection 2
c.Sub("sub2")
// sub should not be corrupted
require.Equal(t, "val1", sub.Value("key"))
})
}