forked from TrueCloudLab/frostfs-s3-gw
ab8dd4201c
Supported X-Amz-Copy-Source-If-Modified-Since and X-Amz-Copy-Source-If-Unmodified-Since. Signed-off-by: Denis Kirillov <denis@nspcc.ru>
137 lines
4 KiB
Go
137 lines
4 KiB
Go
package handler
|
|
|
|
import (
|
|
"net/http"
|
|
"net/url"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/gorilla/mux"
|
|
"github.com/nspcc-dev/neofs-s3-gw/api"
|
|
"github.com/nspcc-dev/neofs-s3-gw/api/layer"
|
|
"go.uber.org/zap"
|
|
)
|
|
|
|
type copyObjectArgs struct {
|
|
IfModifiedSince time.Time
|
|
IfUnmodifiedSince time.Time
|
|
}
|
|
|
|
// path2BucketObject returns bucket and object.
|
|
func path2BucketObject(path string) (bucket, prefix string) {
|
|
path = strings.TrimPrefix(path, api.SlashSeparator)
|
|
m := strings.Index(path, api.SlashSeparator)
|
|
if m < 0 {
|
|
return path, ""
|
|
}
|
|
return path[:m], path[m+len(api.SlashSeparator):]
|
|
}
|
|
|
|
func (h *handler) CopyObjectHandler(w http.ResponseWriter, r *http.Request) {
|
|
var (
|
|
err error
|
|
inf *layer.ObjectInfo
|
|
|
|
req = mux.Vars(r)
|
|
bkt = req["bucket"]
|
|
obj = req["object"]
|
|
rid = api.GetRequestID(r.Context())
|
|
)
|
|
|
|
src := r.Header.Get("X-Amz-Copy-Source")
|
|
// Check https://docs.aws.amazon.com/AmazonS3/latest/dev/ObjectVersioning.html
|
|
// Regardless of whether you have enabled versioning, each object in your bucket
|
|
// has a version ID. If you have not enabled versioning, Amazon S3 sets the value
|
|
// of the version ID to null. If you have enabled versioning, Amazon S3 assigns a
|
|
// unique version ID value for the object.
|
|
if u, err := url.Parse(src); err == nil {
|
|
// Check if versionId query param was added, if yes then check if
|
|
// its non "null" value, we should error out since we do not support
|
|
// any versions other than "null".
|
|
if vid := u.Query().Get("versionId"); vid != "" && vid != "null" {
|
|
api.WriteErrorResponse(r.Context(), w, api.Error{
|
|
Code: api.GetAPIError(api.ErrNoSuchVersion).Code,
|
|
Description: "",
|
|
HTTPStatusCode: http.StatusBadRequest,
|
|
}, r.URL)
|
|
|
|
return
|
|
}
|
|
|
|
src = u.Path
|
|
}
|
|
|
|
srcBucket, srcObject := path2BucketObject(src)
|
|
|
|
args, err := parseCopyObjectArgs(r.Header)
|
|
if err != nil {
|
|
writeError(w, r, h.log, "could not parse request params ", rid, bkt, obj, err)
|
|
return
|
|
}
|
|
|
|
if inf, err = h.obj.GetObjectInfo(r.Context(), srcBucket, srcObject); err != nil {
|
|
writeError(w, r, h.log, "could not find object", rid, bkt, obj, err)
|
|
return
|
|
}
|
|
|
|
if !args.IfModifiedSince.IsZero() && inf.Created.Before(args.IfModifiedSince) {
|
|
w.WriteHeader(http.StatusNotModified)
|
|
return
|
|
}
|
|
if !args.IfUnmodifiedSince.IsZero() && inf.Created.After(args.IfUnmodifiedSince) {
|
|
w.WriteHeader(http.StatusPreconditionFailed)
|
|
return
|
|
}
|
|
|
|
params := &layer.CopyObjectParams{
|
|
SrcBucket: srcBucket,
|
|
DstBucket: bkt,
|
|
SrcObject: srcObject,
|
|
DstObject: obj,
|
|
SrcSize: inf.Size,
|
|
Header: inf.Headers,
|
|
}
|
|
|
|
if inf, err = h.obj.CopyObject(r.Context(), params); err != nil {
|
|
writeErrorCopy(w, r, h.log, "could not copy object", rid, bkt, obj, srcBucket, srcObject, err)
|
|
return
|
|
} else if err = api.EncodeToResponse(w, &CopyObjectResponse{LastModified: inf.Created.Format(time.RFC3339), ETag: inf.HashSum}); err != nil {
|
|
writeErrorCopy(w, r, h.log, "something went wrong", rid, bkt, obj, srcBucket, srcObject, err)
|
|
return
|
|
}
|
|
|
|
h.log.Info("object is copied",
|
|
zap.String("bucket", inf.Bucket),
|
|
zap.String("object", inf.Name),
|
|
zap.Stringer("object_id", inf.ID()))
|
|
}
|
|
|
|
func writeErrorCopy(w http.ResponseWriter, r *http.Request, log *zap.Logger, msg, rid, bkt, obj, srcBucket, srcObject string, err error) {
|
|
log.Error(msg,
|
|
zap.String("request_id", rid),
|
|
zap.String("dst_bucket_name", bkt),
|
|
zap.String("dst_object_name", obj),
|
|
zap.String("src_bucket_name", srcBucket),
|
|
zap.String("src_object_name", srcObject),
|
|
zap.Error(err))
|
|
|
|
api.WriteErrorResponse(r.Context(), w, api.Error{
|
|
Code: api.GetAPIError(api.ErrInternalError).Code,
|
|
Description: err.Error(),
|
|
HTTPStatusCode: http.StatusInternalServerError,
|
|
}, r.URL)
|
|
}
|
|
|
|
func parseCopyObjectArgs(headers http.Header) (*copyObjectArgs, error) {
|
|
var err error
|
|
args := ©ObjectArgs{}
|
|
|
|
if args.IfModifiedSince, err = parseHTTPTime(headers.Get(api.AmzCopyIfModifiedSince)); err != nil {
|
|
return nil, err
|
|
}
|
|
if args.IfUnmodifiedSince, err = parseHTTPTime(headers.Get(api.AmzCopyIfUnmodifiedSince)); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return args, nil
|
|
}
|