From 060642ad14a5636717c540e175a9f735ab149d77 Mon Sep 17 00:00:00 2001 From: Nick Craig-Wood Date: Mon, 28 Dec 2020 12:26:23 +0000 Subject: [PATCH] flags: improve error message when reading environment vars #4888 The message now includes the flag name to help the user work out what is happening. Invalid value for environment variable "RCLONE_VERSION" when setting default for --version: strconv.ParseBool: parsing "yes": invalid syntax --- fs/config/flags/flags.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/config/flags/flags.go b/fs/config/flags/flags.go index 39b5db0ea..d248249f4 100644 --- a/fs/config/flags/flags.go +++ b/fs/config/flags/flags.go @@ -19,13 +19,13 @@ func setDefaultFromEnv(flags *pflag.FlagSet, name string) { if found { flag := flags.Lookup(name) if flag == nil { - log.Fatalf("Couldn't find flag %q", name) + log.Fatalf("Couldn't find flag --%q", name) } err := flag.Value.Set(newValue) if err != nil { - log.Fatalf("Invalid value for environment variable %q: %v", key, err) + log.Fatalf("Invalid value for environment variable %q when setting default for --%s: %v", key, name, err) } - fs.Debugf(nil, "Set default for %q from %q to %q (%v)", name, key, newValue, flag.Value) + fs.Debugf(nil, "Set default for --%q from %q to %q (%v)", name, key, newValue, flag.Value) flag.DefValue = newValue } }