KurlesHS/rclone
1
0
Fork 0
forked from TrueCloudLab/rclone
Code Pull requests Activity

rc: fix job tests on Windows

Browse source
This commit is contained in:
Nick Craig-Wood 2018-11-06 12:01:02 +00:00
parent 2b1194c57e
commit 57b85b8155
1 changed files with 18 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
fs/rc/job_test.go
View file

@ -82,9 +82,20 @@ var longFn = func(in Params) (Params, error) {
return nil, nil return nil, nil
} }
const (
sleepTime = 100 * time.Millisecond
floatSleepTime = float64(sleepTime) / 1E9 / 2
)
// sleep for some time so job.Duration is non-0
func sleepJob() {
time.Sleep(sleepTime)
}
func TestJobFinish(t *testing.T) { func TestJobFinish(t *testing.T) {
jobs := newJobs() jobs := newJobs()
job := jobs.NewJob(longFn, Params{}) job := jobs.NewJob(longFn, Params{})
sleepJob()
assert.Equal(t, true, job.EndTime.IsZero()) assert.Equal(t, true, job.EndTime.IsZero())
assert.Equal(t, Params(nil), job.Output) assert.Equal(t, Params(nil), job.Output)
@ -98,27 +109,29 @@ func TestJobFinish(t *testing.T) {
assert.Equal(t, false, job.EndTime.IsZero()) assert.Equal(t, false, job.EndTime.IsZero())
assert.Equal(t, wantOut, job.Output) assert.Equal(t, wantOut, job.Output)
assert.NotEqual(t, 0.0, job.Duration) assert.True(t, job.Duration >= floatSleepTime)
assert.Equal(t, "", job.Error) assert.Equal(t, "", job.Error)
assert.Equal(t, true, job.Success) assert.Equal(t, true, job.Success)
assert.Equal(t, true, job.Finished) assert.Equal(t, true, job.Finished)
job = jobs.NewJob(longFn, Params{}) job = jobs.NewJob(longFn, Params{})
sleepJob()
job.finish(nil, nil) job.finish(nil, nil)
assert.Equal(t, false, job.EndTime.IsZero()) assert.Equal(t, false, job.EndTime.IsZero())
assert.Equal(t, Params{}, job.Output) assert.Equal(t, Params{}, job.Output)
assert.NotEqual(t, 0.0, job.Duration) assert.True(t, job.Duration >= floatSleepTime)
assert.Equal(t, "", job.Error) assert.Equal(t, "", job.Error)
assert.Equal(t, true, job.Success) assert.Equal(t, true, job.Success)
assert.Equal(t, true, job.Finished) assert.Equal(t, true, job.Finished)
job = jobs.NewJob(longFn, Params{}) job = jobs.NewJob(longFn, Params{})
sleepJob()
job.finish(wantOut, errors.New("potato")) job.finish(wantOut, errors.New("potato"))
assert.Equal(t, false, job.EndTime.IsZero()) assert.Equal(t, false, job.EndTime.IsZero())
assert.Equal(t, wantOut, job.Output) assert.Equal(t, wantOut, job.Output)
assert.NotEqual(t, 0.0, job.Duration) assert.True(t, job.Duration >= floatSleepTime)
assert.Equal(t, "potato", job.Error) assert.Equal(t, "potato", job.Error)
assert.Equal(t, false, job.Success) assert.Equal(t, false, job.Success)
assert.Equal(t, true, job.Finished) assert.Equal(t, true, job.Finished)
@ -129,6 +142,7 @@ func TestJobFinish(t *testing.T) {
func TestJobRunPanic(t *testing.T) { func TestJobRunPanic(t *testing.T) {
wait := make(chan struct{}) wait := make(chan struct{})
boom := func(in Params) (Params, error) { boom := func(in Params) (Params, error) {
sleepJob()
defer close(wait) defer close(wait)
panic("boom") panic("boom")
} }
@ -152,7 +166,7 @@ func TestJobRunPanic(t *testing.T) {
job.mu.Lock() job.mu.Lock()
assert.Equal(t, false, job.EndTime.IsZero()) assert.Equal(t, false, job.EndTime.IsZero())
assert.Equal(t, Params{}, job.Output) assert.Equal(t, Params{}, job.Output)
assert.NotEqual(t, 0.0, job.Duration) assert.True(t, job.Duration >= floatSleepTime)
assert.Equal(t, "panic received: boom", job.Error) assert.Equal(t, "panic received: boom", job.Error)
assert.Equal(t, false, job.Success) assert.Equal(t, false, job.Success)
assert.Equal(t, true, job.Finished) assert.Equal(t, true, job.Finished)