KurlesHS/rclone
1
0
Fork 0
forked from TrueCloudLab/rclone
Code Pull requests Activity

oauthutil: Allow the http.Client to be passed in

Browse source
This commit is contained in:
Nick Craig-Wood 2017-11-24 09:07:03 +00:00
parent 02ffd43572
commit 729e1305b7
2 changed files with 15 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
googlecloudstorage/googlecloudstorage.go
View file

@ -280,7 +280,7 @@ func getServiceAccountClient(keyJsonfilePath string) (*http.Client, error) {
if err != nil { if err != nil {
return nil, errors.Wrap(err, "error processing credentials") return nil, errors.Wrap(err, "error processing credentials")
} }
ctxWithSpecialClient := oauthutil.Context() ctxWithSpecialClient := oauthutil.Context(fs.Config.Client())
return oauth2.NewClient(ctxWithSpecialClient, conf.TokenSource(ctxWithSpecialClient)), nil return oauth2.NewClient(ctxWithSpecialClient, conf.TokenSource(ctxWithSpecialClient)), nil
} }

20
oauthutil/oauthutil.go
View file

@ -189,8 +189,8 @@ func (ts *TokenSource) OnExpiry() <-chan time.Time {
var _ oauth2.TokenSource = (*TokenSource)(nil) var _ oauth2.TokenSource = (*TokenSource)(nil)
// Context returns a context with our HTTP Client baked in for oauth2 // Context returns a context with our HTTP Client baked in for oauth2
func Context() context.Context { func Context(client *http.Client) context.Context {
return context.WithValue(context.Background(), oauth2.HTTPClient, fs.Config.Client()) return context.WithValue(context.Background(), oauth2.HTTPClient, client)
} }
// overrideCredentials sets the ClientID and ClientSecret from the // overrideCredentials sets the ClientID and ClientSecret from the
@ -224,9 +224,11 @@ func overrideCredentials(name string, origConfig *oauth2.Config) (config *oauth2
return config, changed return config, changed
} }
// NewClient gets a token from the config file and configures a Client // NewClientWithBaseClient gets a token from the config file and
// with it. It returns the client and a TokenSource which Invalidate may need to be called on // configures a Client with it. It returns the client and a
func NewClient(name string, config *oauth2.Config) (*http.Client, *TokenSource, error) { // TokenSource which Invalidate may need to be called on. It uses the
// httpClient passed in as the base client.
func NewClientWithBaseClient(name string, config *oauth2.Config, baseClient *http.Client) (*http.Client, *TokenSource, error) {
config, _ = overrideCredentials(name, config) config, _ = overrideCredentials(name, config)
token, err := GetToken(name) token, err := GetToken(name)
if err != nil { if err != nil {
@ -234,7 +236,7 @@ func NewClient(name string, config *oauth2.Config) (*http.Client, *TokenSource,
} }
// Set our own http client in the context // Set our own http client in the context
ctx := Context() ctx := Context(baseClient)
// Wrap the TokenSource in our TokenSource which saves changed // Wrap the TokenSource in our TokenSource which saves changed
// tokens in the config file // tokens in the config file
@ -248,6 +250,12 @@ func NewClient(name string, config *oauth2.Config) (*http.Client, *TokenSource,
} }
// NewClient gets a token from the config file and configures a Client
// with it. It returns the client and a TokenSource which Invalidate may need to be called on
func NewClient(name string, config *oauth2.Config) (*http.Client, *TokenSource, error) {
return NewClientWithBaseClient(name, config, fs.Config.Client())
}
// Config does the initial creation of the token // Config does the initial creation of the token
// //
// It may run an internal webserver to receive the results // It may run an internal webserver to receive the results