KurlesHS/rclone
1
0
Fork 0
forked from TrueCloudLab/rclone
Code Pull requests Activity

vfs: Fix panic on rename with --dry-run set - fixes #2911

Browse source
This commit is contained in:
Nick Craig-Wood 2019-01-14 12:07:25 +00:00
parent 5e5578d2c3
commit bd11d3cb62
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
vfs/file.go
View file

@ -123,6 +123,12 @@ func (f *File) rename(destDir *Dir, newName string) error {
fs.Errorf(f.Path(), "File.Rename error: %v", err) fs.Errorf(f.Path(), "File.Rename error: %v", err)
return err return err
} }
// newObject can be nil here for example if --dry-run
if newObject == nil {
err = errors.New("rename failed: nil object returned")
fs.Errorf(f.Path(), "File.Rename %v", err)
return err
}
// Update the node with the new details // Update the node with the new details
fs.Debugf(f.o, "Updating file with %v %p", newObject, f) fs.Debugf(f.o, "Updating file with %v %p", newObject, f)
// f.rename(destDir, newObject) // f.rename(destDir, newObject)