KurlesHS/restic
1
0
Fork 0
forked from TrueCloudLab/restic
Code Pull requests Activity

internal/cache: extend description of cache sharing test failure

Browse source
This commit is contained in:
Michael Eischer 2022-09-24 13:07:01 +02:00
parent 1220fe9650
commit 7fc178aaf4
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
internal/cache/file_test.go vendored
View file

@ -207,10 +207,13 @@ func TestFileLoad(t *testing.T) {
// Simulate multiple processes writing to a cache, using goroutines. // Simulate multiple processes writing to a cache, using goroutines.
// //
// The possibility of sharing a cache between multiple concurrent restic // The possibility of sharing a cache between multiple concurrent restic
// processes isn't guaranteed in the docs and doesn't always work on Windows // processes isn't guaranteed in the docs and doesn't always work on Windows, hence the
// due to the Go runtime opening files without FILE_SHARE_DELETE, hence the // check on GOOS. Cache sharing is considered a "nice to have" on POSIX, for now.
// check on GOOS. This is considered a "nice to have" on POSIX, for now.
// //
// The cache first creates a temporary file and then renames it to its final name.
// On Windows renaming internally creates a file handle with a shareMode which
// includes FILE_SHARE_DELETE. The Go runtime opens files without FILE_SHARE_DELETE,
// thus Open(fn) will fail until the file handle used for renaming was closed.
// See https://devblogs.microsoft.com/oldnewthing/20211022-00/?p=105822 // See https://devblogs.microsoft.com/oldnewthing/20211022-00/?p=105822
// for hints on how to fix this properly. // for hints on how to fix this properly.
func TestFileSaveConcurrent(t *testing.T) { func TestFileSaveConcurrent(t *testing.T) {