KurlesHS/restic
1
0
Fork 0
forked from TrueCloudLab/restic
Code Pull requests Activity

CI: enable bodyclose linter

Browse source
This commit is contained in:
Michael Eischer 2024-01-06 15:38:57 +01:00
parent b1a8fd1d03
commit bd883caae1
3 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
.golangci.yml
View file

@ -35,6 +35,9 @@ linters:
# parse and typecheck code # parse and typecheck code
- typecheck - typecheck
# ensure that http response bodies are closed
- bodyclose
issues: issues:
# don't use the default exclude rules, this hides (among others) ignored # don't use the default exclude rules, this hides (among others) ignored
# errors from Close() calls # errors from Close() calls

1
internal/backend/limiter/static_limiter_test.go
View file

@ -118,6 +118,7 @@ func TestRoundTripperReader(t *testing.T) {
test.Assert(t, bytes.Equal(data, out.Bytes()), "data ping-pong failed") test.Assert(t, bytes.Equal(data, out.Bytes()), "data ping-pong failed")
} }
// nolint:bodyclose // the http response is just a mock
func TestRoundTripperCornerCases(t *testing.T) { func TestRoundTripperCornerCases(t *testing.T) {
limiter := NewStaticLimiter(Limits{42 * 1024, 42 * 1024}) limiter := NewStaticLimiter(Limits{42 * 1024, 42 * 1024})

1
internal/backend/rclone/backend.go
View file

@ -252,6 +252,7 @@ func newBackend(ctx context.Context, cfg Config, lim limiter.Limiter) (*Backend,
return nil, fmt.Errorf("error talking HTTP to rclone: %w", err) return nil, fmt.Errorf("error talking HTTP to rclone: %w", err)
} }
_ = res.Body.Close()
debug.Log("HTTP status %q returned, moving instance to background", res.Status) debug.Log("HTTP status %q returned, moving instance to background", res.Status)
err = bg() err = bg()
if err != nil { if err != nil {