forked from TrueCloudLab/restic
5756c96c9f
In some rare cases files could be created which contain null IDs (all zero) in their content list. This was caused by a race condition between growing the `Content` slice and inserting the blob IDs into it. In some cases the blob ID was written to the old slice, which a short time afterwards was replaced with a larger copy, that did not yet contain the blob ID.
124 lines
2.4 KiB
Go
124 lines
2.4 KiB
Go
package archiver
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"runtime"
|
|
"sync"
|
|
"sync/atomic"
|
|
"testing"
|
|
|
|
"github.com/restic/restic/internal/errors"
|
|
"github.com/restic/restic/internal/index"
|
|
"github.com/restic/restic/internal/restic"
|
|
"golang.org/x/sync/errgroup"
|
|
)
|
|
|
|
var errTest = errors.New("test error")
|
|
|
|
type saveFail struct {
|
|
idx restic.MasterIndex
|
|
cnt int32
|
|
failAt int32
|
|
}
|
|
|
|
func (b *saveFail) SaveBlob(ctx context.Context, t restic.BlobType, buf []byte, id restic.ID, storeDuplicates bool) (restic.ID, bool, int, error) {
|
|
val := atomic.AddInt32(&b.cnt, 1)
|
|
if val == b.failAt {
|
|
return restic.ID{}, false, 0, errTest
|
|
}
|
|
|
|
return id, false, 0, nil
|
|
}
|
|
|
|
func (b *saveFail) Index() restic.MasterIndex {
|
|
return b.idx
|
|
}
|
|
|
|
func TestBlobSaver(t *testing.T) {
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
defer cancel()
|
|
|
|
wg, ctx := errgroup.WithContext(ctx)
|
|
saver := &saveFail{
|
|
idx: index.NewMasterIndex(),
|
|
}
|
|
|
|
b := NewBlobSaver(ctx, wg, saver, uint(runtime.NumCPU()))
|
|
|
|
var wait sync.WaitGroup
|
|
var results []SaveBlobResponse
|
|
var lock sync.Mutex
|
|
|
|
wait.Add(20)
|
|
for i := 0; i < 20; i++ {
|
|
buf := &Buffer{Data: []byte(fmt.Sprintf("foo%d", i))}
|
|
idx := i
|
|
lock.Lock()
|
|
results = append(results, SaveBlobResponse{})
|
|
lock.Unlock()
|
|
b.Save(ctx, restic.DataBlob, buf, func(res SaveBlobResponse) {
|
|
lock.Lock()
|
|
results[idx] = res
|
|
lock.Unlock()
|
|
wait.Done()
|
|
})
|
|
}
|
|
|
|
wait.Wait()
|
|
for i, sbr := range results {
|
|
if sbr.known {
|
|
t.Errorf("blob %v is known, that should not be the case", i)
|
|
}
|
|
}
|
|
|
|
b.TriggerShutdown()
|
|
|
|
err := wg.Wait()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
func TestBlobSaverError(t *testing.T) {
|
|
var tests = []struct {
|
|
blobs int
|
|
failAt int
|
|
}{
|
|
{20, 2},
|
|
{20, 5},
|
|
{20, 15},
|
|
{200, 150},
|
|
}
|
|
|
|
for _, test := range tests {
|
|
t.Run("", func(t *testing.T) {
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
defer cancel()
|
|
|
|
wg, ctx := errgroup.WithContext(ctx)
|
|
saver := &saveFail{
|
|
idx: index.NewMasterIndex(),
|
|
failAt: int32(test.failAt),
|
|
}
|
|
|
|
b := NewBlobSaver(ctx, wg, saver, uint(runtime.NumCPU()))
|
|
|
|
for i := 0; i < test.blobs; i++ {
|
|
buf := &Buffer{Data: []byte(fmt.Sprintf("foo%d", i))}
|
|
b.Save(ctx, restic.DataBlob, buf, func(res SaveBlobResponse) {})
|
|
}
|
|
|
|
b.TriggerShutdown()
|
|
|
|
err := wg.Wait()
|
|
if err == nil {
|
|
t.Errorf("expected error not found")
|
|
}
|
|
|
|
if err != errTest {
|
|
t.Fatalf("unexpected error found: %v", err)
|
|
}
|
|
})
|
|
}
|
|
}
|