From 2716000b0846b8a01ef18b0c40cfc3443f756e3b Mon Sep 17 00:00:00 2001 From: Alex Vanin Date: Wed, 14 Apr 2021 11:47:42 +0300 Subject: [PATCH] [#477] engine: Make generateShardID function independent This function does not use any engine internal states. This way it can be reused in tests. Signed-off-by: Alex Vanin --- pkg/local_object_storage/engine/shards.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/local_object_storage/engine/shards.go b/pkg/local_object_storage/engine/shards.go index efb2652a1..57cb07cac 100644 --- a/pkg/local_object_storage/engine/shards.go +++ b/pkg/local_object_storage/engine/shards.go @@ -24,7 +24,7 @@ func (e *StorageEngine) AddShard(opts ...shard.Option) (*shard.ID, error) { e.mtx.Lock() defer e.mtx.Unlock() - id, err := e.generateShardID() + id, err := generateShardID() if err != nil { return nil, errors.Wrap(err, "could not generate shard ID") } @@ -37,7 +37,7 @@ func (e *StorageEngine) AddShard(opts ...shard.Option) (*shard.ID, error) { return id, nil } -func (e *StorageEngine) generateShardID() (*shard.ID, error) { +func generateShardID() (*shard.ID, error) { uid, err := uuid.NewRandom() if err != nil { return nil, err