Linter fixes #2

Merged

realloc merged 1 commit from fyrchik/basic:linter-fixes into master

2023-07-26 21:08:06 +00:00

fyrchik commented

2023-06-25 09:57:50 +00:00

Owner

All mandatory linters either catch bugs, enforce common codestyle (gofmt, goimports) or are useful and quite easy to follow (exhaustive, whitespace).

For extra linters:

godot feels context dependent (we know it has some "false" positives)
predeclared is ok, but may seem optional -- short-lived variables could be named better (like I loathe writing ln for length instead of len).
reassign -- sometimes can (?) be necessary
containedctx is ok, but sometimes hard to fix in already existing code and can be violated sometimes (gRPC is a prominent example)
funlen, gocognit -- both of them a mandatory to me, but I believe different settings can be tolerated.
contextcheck -- hard to fix, sometimes has false positives (and sometimes doesn't catch everything we would like).

I would actually leave only containedctx, godot and contextcheck in the extra section: for other linters it is easy to find proper settings or add an exception with a comment.

All mandatory linters either catch bugs, enforce common codestyle (gofmt, goimports) or are useful and quite easy to follow (exhaustive, whitespace). For extra linters: - `godot` feels context dependent (we know it has some "false" positives) - `predeclared` is ok, but may seem optional -- short-lived variables could be named better (like I loathe writing `ln` for length instead of `len`). - `reassign` -- sometimes can (?) be necessary - `containedctx` is ok, but sometimes hard to fix in already existing code and can be violated _sometimes_ (gRPC is a prominent example) - `funlen`, `gocognit` -- both of them a mandatory to me, but I believe different settings can be tolerated. - `contextcheck` -- hard to fix, sometimes has false positives (and sometimes doesn't catch everything we would like). I would actually leave only `containedctx`, `godot` and `contextcheck` in the extra section: for other linters it is easy to find proper settings or add an exception with a comment.