Synchronize with frostfs-node repository #4

New issue

Closed

opened 2024-07-12 08:08:13 +00:00 by george.bartolomey · 3 comments

george.bartolomey commented

2024-07-12 08:08:13 +00:00

Member

frostfs-node is ahead of this repository. If we want to distribute basic template across all repositories, we need to pull changes from frostfs-node first.

frostfs-node is ahead of this repository. If we want to distribute `basic` template across all repositories, we need to pull changes from frostfs-node first.

george.bartolomey commented

2024-07-12 08:25:43 +00:00

Author

Member

Important differences:

gitlint removed
golangci-lint uses fixed version and runs via make lint
gofumpt added (runs via make fumpt)
go-staticcheck-repo-mod and go-mod-tidy added

How to transfer changes from frostfs-node, if we don't use Makefile in basic repo? Maybe, alternative method of installing local gofumpt and golangci-lint needed? Dedicated hidden make file (.linters.mk) or shell script?

Important differences: - `gitlint` removed - `golangci-lint` uses fixed version and runs via `make lint` - `gofumpt` added (runs via `make fumpt`) - `go-staticcheck-repo-mod` and `go-mod-tidy` added How to transfer changes from `frostfs-node`, if we don't use Makefile in basic repo? Maybe, alternative method of installing local `gofumpt` and `golangci-lint` needed? Dedicated hidden `make` file (`.linters.mk`) or shell script?

fyrchik commented

2024-07-12 12:54:09 +00:00

Owner

gitlint removed -- yes, we use DCO action on CI, it annoys us during development.
golanci-lint -- the version is pinned in repo, the target is shared. A separate makefile which we can just copy and then include in the main file is ok.

We can use Makefile here, this repo serves as a starting example.

gitlint removed -- yes, we use DCO action on CI, it annoys us during development. golanci-lint -- the version is pinned in repo, the target is shared. A separate makefile which we can just copy and then include in the main file is ok. We can use Makefile here, this repo serves as a _starting_ example.

george.bartolomey commented

2024-07-12 13:30:13 +00:00

Author

Member

@fyrchik, Is it worth applying these changes to basic?