From 9787728fbd73ea04b70de56cdb75b8ac8ed5e61f Mon Sep 17 00:00:00 2001
From: Herman Slatman <hermanslatman@hotmail.com>
Date: Fri, 16 Apr 2021 14:09:34 +0200
Subject: [PATCH] Mask challenge password after it has been read

---
 authority/provisioner/scep.go | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/authority/provisioner/scep.go b/authority/provisioner/scep.go
index 6af3dc83..7f3cce8f 100644
--- a/authority/provisioner/scep.go
+++ b/authority/provisioner/scep.go
@@ -20,6 +20,8 @@ type SCEP struct {
 	Options           *Options `json:"options,omitempty"`
 	Claims            *Claims  `json:"claims,omitempty"`
 	claimer           *Claimer
+
+	secretChallengePassword string
 }
 
 // GetID returns the provisioner unique identifier.
@@ -73,6 +75,10 @@ func (s *SCEP) Init(config Config) (err error) {
 		return err
 	}
 
+	// Mask the actual challenge value, so it won't be marshalled
+	s.secretChallengePassword = s.ChallengePassword
+	s.ChallengePassword = "*** redacted ***"
+
 	// TODO: add other, SCEP specific, options?
 
 	return err
@@ -95,7 +101,7 @@ func (s *SCEP) AuthorizeSign(ctx context.Context, token string) ([]SignOption, e
 
 // GetChallengePassword returns the challenge password
 func (s *SCEP) GetChallengePassword() string {
-	return s.ChallengePassword
+	return s.secretChallengePassword
 }
 
 // GetCapabilities returns the CA capabilities