From aafd6be44afd08ad142585b6daeb820101d1937c Mon Sep 17 00:00:00 2001
From: Mariano Cano <mariano@smallstep.com>
Date: Fri, 17 Jul 2020 18:07:33 -0700
Subject: [PATCH] Add tests for SerialNumber.

---
 x509util/extensions_test.go | 89 ++++++++++++++++++++++++++++++++++++-
 1 file changed, 88 insertions(+), 1 deletion(-)

diff --git a/x509util/extensions_test.go b/x509util/extensions_test.go
index 71a00a09..2938e0eb 100644
--- a/x509util/extensions_test.go
+++ b/x509util/extensions_test.go
@@ -4,6 +4,7 @@ import (
 	"crypto/x509"
 	"crypto/x509/pkix"
 	"encoding/asn1"
+	"math/big"
 	"net"
 	"net/url"
 	"reflect"
@@ -163,7 +164,7 @@ func TestObjectIdentifier_UnmarshalJSON(t *testing.T) {
 		{"empty", args{[]byte(`""`)}, []int{}, false},
 		{"null", args{[]byte(`null`)}, []int{}, false},
 		{"number", args{[]byte(`123`)}, nil, true},
-		{"badFormat", args{[]byte(`"1.2.foo.4`)}, nil, true},
+		{"badFormat", args{[]byte(`"1.2.foo.4"`)}, nil, true},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
@@ -660,3 +661,89 @@ func TestNameConstraints_Set(t *testing.T) {
 		})
 	}
 }
+
+func TestSerialNumber_Set(t *testing.T) {
+	type fields struct {
+		Int *big.Int
+	}
+	type args struct {
+		c *x509.Certificate
+	}
+	tests := []struct {
+		name   string
+		fields fields
+		args   args
+		want   *x509.Certificate
+	}{
+		{"ok", fields{big.NewInt(1234)}, args{&x509.Certificate{}}, &x509.Certificate{SerialNumber: big.NewInt(1234)}},
+		{"overwrite", fields{big.NewInt(4321)}, args{&x509.Certificate{SerialNumber: big.NewInt(1234)}}, &x509.Certificate{SerialNumber: big.NewInt(4321)}},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			s := SerialNumber{
+				Int: tt.fields.Int,
+			}
+			s.Set(tt.args.c)
+			if !reflect.DeepEqual(tt.args.c, tt.want) {
+				t.Errorf("SerialNumber.Set() = %v, want %v", tt.args.c, tt.want)
+			}
+		})
+	}
+}
+
+func TestSerialNumber_MarshalJSON(t *testing.T) {
+	tests := []struct {
+		name    string
+		sn      *SerialNumber
+		want    []byte
+		wantErr bool
+	}{
+		{"ok", &SerialNumber{big.NewInt(1234)}, []byte("1234"), false},
+		{"nilStruct", nil, []byte("null"), false},
+		{"nilBigInt", &SerialNumber{}, []byte("null"), false},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got, err := tt.sn.MarshalJSON()
+			if (err != nil) != tt.wantErr {
+				t.Errorf("SerialNumber.MarshalJSON() error = %v, wantErr %v", err, tt.wantErr)
+				return
+			}
+			if !reflect.DeepEqual(got, tt.want) {
+				t.Errorf("SerialNumber.MarshalJSON() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}
+
+func TestSerialNumber_UnmarshalJSON(t *testing.T) {
+	expected := SerialNumber{big.NewInt(12345)}
+
+	type args struct {
+		data []byte
+	}
+	tests := []struct {
+		name    string
+		args    args
+		want    SerialNumber
+		wantErr bool
+	}{
+		{"string", args{[]byte(`"12345"`)}, expected, false},
+		{"stringHex", args{[]byte(`"0x3039"`)}, expected, false},
+		{"number", args{[]byte(`12345`)}, expected, false},
+		{"badString", args{[]byte(`"123s"`)}, SerialNumber{}, true},
+		{"object", args{[]byte(`{}`)}, SerialNumber{}, true},
+		{"badJSON", args{[]byte(`{`)}, SerialNumber{}, true},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			var s SerialNumber
+			if err := s.UnmarshalJSON(tt.args.data); (err != nil) != tt.wantErr {
+				t.Errorf("SerialNumber.UnmarshalJSON() error = %v, wantErr %v", err, tt.wantErr)
+			}
+			if !reflect.DeepEqual(s, tt.want) {
+				t.Errorf("SerialNumber.UnmarshalJSON() = %v, want %v", s, tt.want)
+			}
+		})
+	}
+}