ef16febf40
The ACME EAB keys are now also indexed by the provisioner. This solves part of the issue in which too many EAB keys may be in memory at a given time.
235 lines
7.6 KiB
Go
235 lines
7.6 KiB
Go
package api
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"net/http"
|
|
|
|
"github.com/go-chi/chi"
|
|
"github.com/smallstep/certificates/acme"
|
|
"github.com/smallstep/certificates/api"
|
|
"github.com/smallstep/certificates/authority/admin"
|
|
"github.com/smallstep/certificates/authority/provisioner"
|
|
"go.step.sm/linkedca"
|
|
"google.golang.org/protobuf/types/known/timestamppb"
|
|
)
|
|
|
|
const (
|
|
// provisionerContextKey provisioner key
|
|
provisionerContextKey = ContextKey("provisioner")
|
|
)
|
|
|
|
// CreateExternalAccountKeyRequest is the type for POST /admin/acme/eab requests
|
|
type CreateExternalAccountKeyRequest struct {
|
|
Reference string `json:"reference"`
|
|
}
|
|
|
|
// Validate validates a new ACME EAB Key request body.
|
|
func (r *CreateExternalAccountKeyRequest) Validate() error {
|
|
if len(r.Reference) > 256 { // an arbitrary, but sensible (IMO), limit
|
|
return fmt.Errorf("reference length %d exceeds the maximum (256)", len(r.Reference))
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// GetExternalAccountKeysResponse is the type for GET /admin/acme/eab responses
|
|
type GetExternalAccountKeysResponse struct {
|
|
EAKs []*linkedca.EABKey `json:"eaks"`
|
|
}
|
|
|
|
// requireEABEnabled is a middleware that ensures ACME EAB is enabled
|
|
// before serving requests that act on ACME EAB credentials.
|
|
func (h *Handler) requireEABEnabled(next nextHTTP) nextHTTP {
|
|
return func(w http.ResponseWriter, r *http.Request) {
|
|
ctx := r.Context()
|
|
provName := chi.URLParam(r, "prov")
|
|
eabEnabled, prov, err := h.provisionerHasEABEnabled(ctx, provName)
|
|
if err != nil {
|
|
api.WriteError(w, err)
|
|
return
|
|
}
|
|
if !eabEnabled {
|
|
api.WriteError(w, admin.NewError(admin.ErrorBadRequestType, "ACME EAB not enabled for provisioner %s", prov.GetName()))
|
|
return
|
|
}
|
|
ctx = context.WithValue(ctx, provisionerContextKey, prov)
|
|
next(w, r.WithContext(ctx))
|
|
}
|
|
}
|
|
|
|
// provisionerHasEABEnabled determines if the "requireEAB" setting for an ACME
|
|
// provisioner is set to true and thus has EAB enabled.
|
|
func (h *Handler) provisionerHasEABEnabled(ctx context.Context, provisionerName string) (bool, *linkedca.Provisioner, error) {
|
|
var (
|
|
p provisioner.Interface
|
|
err error
|
|
)
|
|
if p, err = h.auth.LoadProvisionerByName(provisionerName); err != nil {
|
|
return false, nil, admin.WrapErrorISE(err, "error loading provisioner %s", provisionerName)
|
|
}
|
|
|
|
prov, err := h.db.GetProvisioner(ctx, p.GetID())
|
|
if err != nil {
|
|
return false, nil, admin.WrapErrorISE(err, "error getting provisioner with ID: %s", p.GetID())
|
|
}
|
|
|
|
details := prov.GetDetails()
|
|
if details == nil {
|
|
return false, nil, admin.NewErrorISE("error getting details for provisioner with ID: %s", p.GetID())
|
|
}
|
|
|
|
acmeProvisioner := details.GetACME()
|
|
if acmeProvisioner == nil {
|
|
return false, nil, admin.NewErrorISE("error getting ACME details for provisioner with ID: %s", p.GetID())
|
|
}
|
|
|
|
return acmeProvisioner.GetRequireEab(), prov, nil
|
|
}
|
|
|
|
// provisionerFromContext searches the context for a provisioner. Returns the
|
|
// provisioner or an error.
|
|
func provisionerFromContext(ctx context.Context) (*linkedca.Provisioner, error) {
|
|
val := ctx.Value(provisionerContextKey)
|
|
if val == nil {
|
|
return nil, admin.NewErrorISE("provisioner expected in request context")
|
|
}
|
|
pval, ok := val.(*linkedca.Provisioner)
|
|
if !ok || pval == nil {
|
|
return nil, admin.NewErrorISE("provisioner in context is not a linkedca.Provisioner")
|
|
}
|
|
return pval, nil
|
|
}
|
|
|
|
// CreateExternalAccountKey creates a new External Account Binding key
|
|
func (h *Handler) CreateExternalAccountKey(w http.ResponseWriter, r *http.Request) {
|
|
var body CreateExternalAccountKeyRequest
|
|
if err := api.ReadJSON(r.Body, &body); err != nil {
|
|
api.WriteError(w, admin.WrapError(admin.ErrorBadRequestType, err, "error reading request body"))
|
|
return
|
|
}
|
|
|
|
if err := body.Validate(); err != nil {
|
|
api.WriteError(w, admin.WrapError(admin.ErrorBadRequestType, err, "error validating request body"))
|
|
return
|
|
}
|
|
|
|
ctx := r.Context()
|
|
prov, err := provisionerFromContext(ctx)
|
|
if err != nil {
|
|
api.WriteError(w, admin.WrapErrorISE(err, "error getting provisioner from context"))
|
|
return
|
|
}
|
|
|
|
// check if a key with the reference does not exist (only when a reference was in the request)
|
|
reference := body.Reference
|
|
if reference != "" {
|
|
k, err := h.acmeDB.GetExternalAccountKeyByReference(ctx, prov.GetId(), reference)
|
|
// retrieving an EAB key from DB results in an error if it doesn't exist, which is what we're looking for,
|
|
// but other errors can also happen. Return early if that happens; continuing if it was acme.ErrNotFound.
|
|
if shouldWriteError := err != nil && !errors.Is(err, acme.ErrNotFound); shouldWriteError {
|
|
api.WriteError(w, admin.WrapErrorISE(err, "could not lookup external account key by reference"))
|
|
return
|
|
}
|
|
// if a key was found, return HTTP 409 conflict
|
|
if k != nil {
|
|
err := admin.NewError(admin.ErrorBadRequestType, "an ACME EAB key for provisioner '%s' with reference '%s' already exists", prov.GetName(), reference)
|
|
err.Status = 409
|
|
api.WriteError(w, err)
|
|
return
|
|
}
|
|
// continue execution if no key was found for the reference
|
|
}
|
|
|
|
eak, err := h.acmeDB.CreateExternalAccountKey(ctx, prov.GetId(), reference)
|
|
if err != nil {
|
|
msg := fmt.Sprintf("error creating ACME EAB key for provisioner '%s'", prov.GetName())
|
|
if reference != "" {
|
|
msg += fmt.Sprintf(" and reference '%s'", reference)
|
|
}
|
|
api.WriteError(w, admin.WrapErrorISE(err, msg))
|
|
return
|
|
}
|
|
|
|
response := &linkedca.EABKey{
|
|
Id: eak.ID,
|
|
HmacKey: eak.KeyBytes,
|
|
Provisioner: prov.GetName(),
|
|
Reference: eak.Reference,
|
|
}
|
|
|
|
api.ProtoJSONStatus(w, response, http.StatusCreated)
|
|
}
|
|
|
|
// DeleteExternalAccountKey deletes an ACME External Account Key.
|
|
func (h *Handler) DeleteExternalAccountKey(w http.ResponseWriter, r *http.Request) {
|
|
|
|
keyID := chi.URLParam(r, "id")
|
|
|
|
ctx := r.Context()
|
|
prov, err := provisionerFromContext(ctx)
|
|
if err != nil {
|
|
api.WriteError(w, admin.WrapErrorISE(err, "error getting provisioner from context"))
|
|
return
|
|
}
|
|
|
|
if err := h.acmeDB.DeleteExternalAccountKey(ctx, prov.GetId(), keyID); err != nil {
|
|
api.WriteError(w, admin.WrapErrorISE(err, "error deleting ACME EAB Key '%s'", keyID))
|
|
return
|
|
}
|
|
|
|
api.JSON(w, &DeleteResponse{Status: "ok"})
|
|
}
|
|
|
|
// GetExternalAccountKeys returns ACME EAB Keys. If a reference is specified,
|
|
// only the ExternalAccountKey with that reference is returned. Otherwise all
|
|
// ExternalAccountKeys in the system for a specific provisioner are returned.
|
|
func (h *Handler) GetExternalAccountKeys(w http.ResponseWriter, r *http.Request) {
|
|
|
|
var (
|
|
key *acme.ExternalAccountKey
|
|
keys []*acme.ExternalAccountKey
|
|
err error
|
|
)
|
|
|
|
ctx := r.Context()
|
|
prov, err := provisionerFromContext(ctx)
|
|
if err != nil {
|
|
api.WriteError(w, admin.WrapErrorISE(err, "error getting provisioner from context"))
|
|
return
|
|
}
|
|
|
|
reference := chi.URLParam(r, "ref")
|
|
if reference != "" {
|
|
if key, err = h.acmeDB.GetExternalAccountKeyByReference(ctx, prov.GetId(), reference); err != nil {
|
|
api.WriteError(w, admin.WrapErrorISE(err, "error retrieving external account key with reference '%s'", reference))
|
|
return
|
|
}
|
|
if key != nil {
|
|
keys = []*acme.ExternalAccountKey{key}
|
|
}
|
|
} else {
|
|
if keys, err = h.acmeDB.GetExternalAccountKeys(ctx, prov.GetId()); err != nil {
|
|
api.WriteError(w, admin.WrapErrorISE(err, "error retrieving external account keys"))
|
|
return
|
|
}
|
|
}
|
|
|
|
provisionerName := prov.GetName()
|
|
eaks := make([]*linkedca.EABKey, len(keys))
|
|
for i, k := range keys {
|
|
eaks[i] = &linkedca.EABKey{
|
|
Id: k.ID,
|
|
HmacKey: []byte{},
|
|
Provisioner: provisionerName,
|
|
Reference: k.Reference,
|
|
Account: k.AccountID,
|
|
CreatedAt: timestamppb.New(k.CreatedAt),
|
|
BoundAt: timestamppb.New(k.BoundAt),
|
|
}
|
|
}
|
|
|
|
api.JSON(w, &GetExternalAccountKeysResponse{
|
|
EAKs: eaks,
|
|
})
|
|
}
|