TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

all: simply registering plugins (#3287)

Browse source 
Abstract the caddy call and make it simpler.

See #3261 for some part of the discussion.

Go from:

~~~ go
func init() {
       caddy.RegisterPlugin("any", caddy.Plugin{
               ServerType: "dns",
               Action:     setup,
       })
}
~~~

To:

~~~ go
func init() { plugin.Register("any", setup) }
~~~

This requires some external documents in coredns.io to be updated as
well; the old way still works, so it's backwards compatible.

Signed-off-by: Miek Gieben <miek@miek.nl>
This commit is contained in:
Miek Gieben 2019-09-20 08:02:30 +01:00 • committed by GitHub
parent 85e65702bd
commit 004c5fca9d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
38 changed files with 54 additions and 220 deletions
Download patch file Download diff file Expand all files Collapse all files

7
plugin/clouddns/setup.go
View file

@ -18,9 +18,8 @@ import (
var log = clog.NewWithPlugin("clouddns")
func init() {
caddy.RegisterPlugin("clouddns", caddy.Plugin{
ServerType: "dns",
Action: func(c *caddy.Controller) error {
plugin.Register("clouddns",
func(c *caddy.Controller) error {
f := func(ctx context.Context, opt option.ClientOption) (gcpDNS, error) {
var err error
var client *gcp.Service
@ -35,7 +34,7 @@ func init() {
}
return setup(c, f)
},
})
)
}
func setup(c *caddy.Controller, f func(ctx context.Context, opt option.ClientOption) (gcpDNS, error)) error {