TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 3 Projects Releases Packages Wiki Activity Actions

Fix a couple of code scanning alerts (#5157)

Browse source 
This PR fixed a couple of code scanning alerts:

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
This commit is contained in:
Yong Tang 2022-02-07 06:09:12 -08:00 • committed by GitHub
parent 69473c5cad
commit 041e1eabc6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
plugin/forward/setup.go
View file

@ -163,13 +163,10 @@ func parseBlock(c *caddy.Controller, f *Forward) error {
if !c.NextArg() { if !c.NextArg() {
return c.ArgErr() return c.ArgErr()
} }
n, err := strconv.Atoi(c.Val()) n, err := strconv.ParseUint(c.Val(), 10, 32)
if err != nil { if err != nil {
return err return err
} }
if n < 0 {
return fmt.Errorf("max_fails can't be negative: %d", n)
}
f.maxfails = uint32(n) f.maxfails = uint32(n)
case "health_check": case "health_check":
if !c.NextArg() { if !c.NextArg() {

2
plugin/whoami/whoami.go
View file

@ -45,7 +45,7 @@ func (wh Whoami) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg)
if state.QName() == "." { if state.QName() == "." {
srv.Hdr.Name = "_" + state.Proto() + state.QName() srv.Hdr.Name = "_" + state.Proto() + state.QName()
} }
port, _ := strconv.Atoi(state.Port()) port, _ := strconv.ParseUint(state.Port(), 10, 16)
srv.Port = uint16(port) srv.Port = uint16(port)
srv.Target = "." srv.Target = "."