TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

plugin/proxy: skip hc for https_google (#1272)

Browse source 
If protocol is https_google we do the health checks wrong, i.e. we're healthchecking the wrong
endpoint, hence the health check code below should not be executed. See issue #1202.
This is an ugly hack and the thing requires a rethink. Possibly in conjunction with moving
to the *forward* plugin.
This commit is contained in:
Miek Gieben 2017-12-07 22:25:05 +00:00 • committed by GitHub
parent 7435db968b
commit 0e8ceea1d6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
plugin/proxy/proxy.go
View file

@ -120,6 +120,14 @@ func (p Proxy) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (
}
}
// If protocol is https_google we do the health checks wrong, i.e. we're healthchecking the wrong
// endpoint, hence the health check code below should not be executed. See issue #1202.
// This is an ugly hack and the thing requires a rethink. Possibly in conjunction with moving
// to the *forward* plugin.
if upstream.Exchanger().Protocol() == "https_google" {
continue
}
timeout := host.FailTimeout
if timeout == 0 {
timeout = defaultFailTimeout