Use gometalinter and enforcing go fmt/lint/vet (#1108)
* Use gometalinter and enforcing go fmt/lint/vet Before this PR go fmt is enabled, go lint is suggest only. From time to time we have to manually check for go lint and go vet for any issues. This fix uses gometalinter and enforcing go fmt/lint/vet. Several reasons: - gometalinter could handle multiple linters concurrently - gometalinter supports suppression with `// nolint[: <linter>]` Previously one reason we didn't enable go lint was due to the ``` warning: context.Context should be the first parameter of a function (golint) ``` this is now possible with gometalinter and `// nolint: golint` (See changes). This fix also discovered several go vet issues and fixes it. Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Fix several issues reported by gometalinter (go vet) This commit fixes several issues reported by gometalinter (go vet). Signed-off-by: Yong Tang <yong.tang.github@outlook.com> * Increase deadline Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
This commit is contained in:
parent
387ceb480b
commit
102cfbd7fe
4 changed files with 9 additions and 15 deletions
|
@ -49,6 +49,6 @@ func send(t *testing.T, server string) {
|
|||
t.Fatalf("Expected successful reply, got %s", dns.RcodeToString[r.Rcode])
|
||||
}
|
||||
if len(r.Extra) != 2 {
|
||||
t.Fatalf("Expected 2 RRs in additional, got %s", len(r.Extra))
|
||||
t.Fatalf("Expected 2 RRs in additional, got %d", len(r.Extra))
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue