TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Move .LocalAddr() out of goroutine (#4281)

Browse source 
I don't have theory why this panics, but concurrency has something to do
with it, so get the address before we call the goroutine.

See #4271

Signed-off-by: Miek Gieben <miek@miek.nl>
This commit is contained in:
Miek Gieben 2020-12-11 17:49:47 +01:00 • committed by GitHub
parent 9db3a2a72e
commit 108d26ebea
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
plugin/cache/handler.go vendored
View file

@ -49,11 +49,12 @@ func (c *Cache) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg)
servedStale.WithLabelValues(server).Inc() servedStale.WithLabelValues(server).Inc()
// Adjust the time to get a 0 TTL in the reply built from a stale item. // Adjust the time to get a 0 TTL in the reply built from a stale item.
now = now.Add(time.Duration(ttl) * time.Second) now = now.Add(time.Duration(ttl) * time.Second)
addr := w.LocalAddr() // See https://github.com/coredns/coredns/issues/4271, unclear how, but pull this out of the goroutine, and get the address here.
go func() { go func() {
if !do { if !do {
setDo(rc) setDo(rc)
} }
crr := &ResponseWriter{Cache: c, state: state, server: server, prefetch: true, remoteAddr: w.LocalAddr(), do: do} crr := &ResponseWriter{Cache: c, state: state, server: server, prefetch: true, remoteAddr: addr, do: do}
plugin.NextOrFailure(c.Name(), c.Next, ctx, crr, rc) plugin.NextOrFailure(c.Name(), c.Next, ctx, crr, rc)
}() }()
} }