TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 4 Projects Releases Packages Wiki Activity Actions

Close the body after reading the response body information (#5907)

Browse source 
Signed-off-by: Fish-pro <zechun.chen@daocloud.io>
This commit is contained in:
Fish-pro 2023-02-16 01:41:51 +08:00 • committed by GitHub
parent 8a0d3ba3ca
commit 156da74ad3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
core/dnsserver/server_https_test.go
View file

@ -61,6 +61,7 @@ func TestCustomHTTPRequestValidator(t *testing.T) {
if res.StatusCode != tc.expected { if res.StatusCode != tc.expected {
t.Error("unexpected HTTP code", res.StatusCode) t.Error("unexpected HTTP code", res.StatusCode)
} }
res.Body.Close()
}) })
} }
} }

2
test/reload_test.go
View file

@ -123,6 +123,7 @@ func TestReloadMetricsHealth(t *testing.T) {
} }
const proc = "coredns_build_info" const proc = "coredns_build_info"
metrics, _ := io.ReadAll(resp.Body) metrics, _ := io.ReadAll(resp.Body)
resp.Body.Close()
if !bytes.Contains(metrics, []byte(proc)) { if !bytes.Contains(metrics, []byte(proc)) {
t.Errorf("Failed to see %s in metric output", proc) t.Errorf("Failed to see %s in metric output", proc)
} }
@ -135,6 +136,7 @@ func collectMetricsInfo(addr string, procs ...string) error {
return err return err
} }
metrics, _ := io.ReadAll(resp.Body) metrics, _ := io.ReadAll(resp.Body)
resp.Body.Close()
for _, p := range procs { for _, p := range procs {
if !bytes.Contains(metrics, []byte(p)) { if !bytes.Contains(metrics, []byte(p)) {
return fmt.Errorf("failed to see %s in metric output \n%s", p, metrics) return fmt.Errorf("failed to see %s in metric output \n%s", p, metrics)