TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Cleanup metrics (#3776)

Browse source 
Cleanup a variety of metric issues.
* Eliminate department of redundancy "count_total" naming.
* Use the plural of the unit when appropriate. (ex, "requests")
* Remove label names from metric names where appropriate. (ex, "rcode")
* Simplify request metrics by consolidating type label in to the base
request counter.
* Re-generate man pages.

Signed-off-by: Ben Kochie <superq@gmail.com>

Co-authored-by: Ben Kochie <superq@gmail.com>
This commit is contained in:
Miek Gieben 2020-03-26 09:17:33 +01:00 • committed by GitHub
parent eb23cce1a7
commit 19cfa2960c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
16 changed files with 39 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

2
plugin/reload/metrics.go
View file

@ -11,7 +11,7 @@ var (
FailedCount = prometheus.NewCounter(prometheus.CounterOpts{
Namespace: plugin.Namespace,
Subsystem: "reload",
Name: "failed_count_total",
Name: "failed_total",
Help: "Counter of the number of failed reload attempts.",
})