TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 4 Projects Releases Packages Wiki Activity Actions

plugin/kubernetes: rename client-go metrics label "url" to "host" (#6040)

Browse source
This commit is contained in:
Yashpal 2023-04-25 23:56:57 +05:30 • committed by GitHub
parent 9455a4e162
commit 1b95a6042d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
plugin/kubernetes/README.md
View file

@ -229,9 +229,9 @@ If monitoring is enabled (via the *prometheus* plugin) then the following metric
* `headless_with_selector`
* `headless_without_selector`
The following are client level metrics to monitor apiserver request latency & status codes. `verb` identifies the apiserver [request type](https://kubernetes.io/docs/reference/using-api/api-concepts/#single-resource-api) and `url`/`host` denotes the apiserver endpoint.
* `coredns_kubernetes_rest_client_request_duration_seconds{verb, url}` - captures apiserver request latency perceived by client grouped by `verb` and `url`.
* `coredns_kubernetes_rest_client_rate_limiter_duration_seconds{verb, url}` - captures apiserver request latency contributed by client side rate limiter grouped by `verb` & `url`.
The following are client level metrics to monitor apiserver request latency & status codes. `verb` identifies the apiserver [request type](https://kubernetes.io/docs/reference/using-api/api-concepts/#single-resource-api) and `host` denotes the apiserver endpoint.
* `coredns_kubernetes_rest_client_request_duration_seconds{verb, host}` - captures apiserver request latency perceived by client grouped by `verb` and `host`.
* `coredns_kubernetes_rest_client_rate_limiter_duration_seconds{verb, host}` - captures apiserver request latency contributed by client side rate limiter grouped by `verb` & `host`.
* `coredns_kubernetes_rest_client_requests_total{method, code, host}` - captures total apiserver requests grouped by `method`, `status_code` & `host`.
## Bugs

12
plugin/kubernetes/metrics.go
View file

@ -13,28 +13,28 @@ import (
)
var (
// requestLatency measures K8s rest client requests latency grouped by verb and url.
// requestLatency measures K8s rest client requests latency grouped by verb and host.
requestLatency = promauto.NewHistogramVec(
prometheus.HistogramOpts{
Namespace: plugin.Namespace,
Subsystem: "kubernetes",
Name: "rest_client_request_duration_seconds",
Help: "Request latency in seconds. Broken down by verb and URL.",
Help: "Request latency in seconds. Broken down by verb and host.",
Buckets: prometheus.DefBuckets,
},
[]string{"verb", "url"},
[]string{"verb", "host"},
)
// rateLimiterLatency measures K8s rest client rate limiter latency grouped by verb and url.
// rateLimiterLatency measures K8s rest client rate limiter latency grouped by verb and host.
rateLimiterLatency = promauto.NewHistogramVec(
prometheus.HistogramOpts{
Namespace: plugin.Namespace,
Subsystem: "kubernetes",
Name: "rest_client_rate_limiter_duration_seconds",
Help: "Client side rate limiter latency in seconds. Broken down by verb and URL.",
Help: "Client side rate limiter latency in seconds. Broken down by verb and host.",
Buckets: prometheus.DefBuckets,
},
[]string{"verb", "url"},
[]string{"verb", "host"},
)
// requestResult measures K8s rest client request metrics grouped by status code, method & host.