From 21fc65bfc8cd8f4fb8c07dde7df40a96339333e3 Mon Sep 17 00:00:00 2001 From: Yong Tang Date: Wed, 16 Mar 2022 09:28:25 -0700 Subject: [PATCH] [plugin/clouddns] Add additional doc in explaining credentials file field is optional (#5231) This PR adds additional doc in explaining credentials file field is optional, in case user might be concerned to save an filename location in Corefile. Technically since Corefile does not save plaintext secret for clouddns (unlikely route53/azure), this is not too big of a concern, as far as I can see. Still it is worth to pointing out in documentation. Signed-off-by: Yong Tang --- plugin/clouddns/README.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/plugin/clouddns/README.md b/plugin/clouddns/README.md index 6ff4a2b24..1e122813f 100644 --- a/plugin/clouddns/README.md +++ b/plugin/clouddns/README.md @@ -34,6 +34,9 @@ clouddns [ZONE:PROJECT_ID:HOSTED_ZONE_NAME...] { accessed. * `credentials` is used for reading the credential file from **FILENAME** (normally a .json file). + This field is optional. If this field is not provided then authentication will be done automatically, + e.g., through environmental variable `GOOGLE_APPLICATION_CREDENTIALS`. Please see + Google Cloud's [authentication method](https://cloud.google.com/docs/authentication) for more details. * `fallthrough` If zone matches and no record can be generated, pass request to the next plugin. If **[ZONES...]** is omitted, then fallthrough happens for all zones for which the plugin is