From 2213a12d21a9a95e2246ebe6bb3e47778f57dae8 Mon Sep 17 00:00:00 2001 From: Miek Gieben Date: Fri, 12 Jul 2019 12:33:27 +0000 Subject: [PATCH] Scrub: TC bit is always set (#3001) miekg/dns recently became more aggressive in setting TC; anything that's chopped of a response results in TC. Amend the tests. Disputable if these TC checks still add something. Signed-off-by: Miek Gieben --- request/request_test.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/request/request_test.go b/request/request_test.go index 4411c6a82..a62fc51bf 100644 --- a/request/request_test.go +++ b/request/request_test.go @@ -98,8 +98,8 @@ func TestRequestScrubExtra(t *testing.T) { if want, got := req.Size(), reply.Len(); want < got { t.Errorf("Want scrub to reduce message length below %d bytes, got %d bytes", want, got) } - if reply.Truncated { - t.Errorf("Want scrub to not set truncated bit") + if !reply.Truncated { + t.Errorf("Want scrub to set truncated bit") } } @@ -120,8 +120,8 @@ func TestRequestScrubExtraEdns0(t *testing.T) { if want, got := req.Size(), reply.Len(); want < got { t.Errorf("Want scrub to reduce message length below %d bytes, got %d bytes", want, got) } - if reply.Truncated { - t.Errorf("Want scrub to not set truncated bit") + if !reply.Truncated { + t.Errorf("Want scrub to set truncated bit") } } @@ -146,8 +146,8 @@ func TestRequestScrubExtraRegression(t *testing.T) { if want, got := req.Size(), reply.Len(); want < got { t.Errorf("Want scrub to reduce message length below %d bytes, got %d bytes", want, got) } - if reply.Truncated { - t.Errorf("Want scrub to not set truncated bit") + if !reply.Truncated { + t.Errorf("Want scrub to set truncated bit") } }