presubmit: Check errorf as well (#1845)

Uppercase all these test errors as well. And extend the presubmit to
check for these in the future. Also do a slightly smarter grep to only
get t.<something>. as (because dump regexp) this also grep over non test
files.
This commit is contained in:
Miek Gieben 2018-06-02 19:48:39 +01:00 committed by Yong Tang
parent 3994d3a5a7
commit 22c0b30d5f
19 changed files with 57 additions and 52 deletions

View file

@ -42,7 +42,7 @@ func (w *writer) Dnstap(e tap.Dnstap) {
w.t.Error("Message not expected.")
}
if !test.MsgEqual(w.queue[0], e.Message) {
w.t.Errorf("want: %v, have: %v", w.queue[0], e.Message)
w.t.Errorf("Want: %v, have: %v", w.queue[0], e.Message)
}
w.queue = w.queue[1:]
}

View file

@ -29,7 +29,7 @@ func TestConfig(t *testing.T) {
} else if err != nil || conf.target != c.path ||
conf.full != c.full || conf.socket != c.socket {
t.Errorf("expected: %+v\nhave: %+v\nerror: %s\n", c, conf, err)
t.Errorf("Expected: %+v\nhave: %+v\nerror: %s\n", c, conf, err)
}
}
}