TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

presubmit: Check errorf as well (#1845)

Browse source 
Uppercase all these test errors as well. And extend the presubmit to
check for these in the future. Also do a slightly smarter grep to only
get t.<something>. as (because dump regexp) this also grep over non test
files.
This commit is contained in:
Miek Gieben 2018-06-02 19:48:39 +01:00 • committed by Yong Tang
parent 3994d3a5a7
commit 22c0b30d5f
19 changed files with 57 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

10
plugin/pkg/response/typify_test.go
View file

@ -14,7 +14,7 @@ func TestTypifyNilMsg(t *testing.T) {
ty, _ := Typify(m, time.Now().UTC())
if ty != OtherError {
t.Errorf("message wrongly typified, expected OtherError, got %s", ty)
t.Errorf("Message wrongly typified, expected OtherError, got %s", ty)
}
}
@ -22,7 +22,7 @@ func TestTypifyDelegation(t *testing.T) {
m := delegationMsg()
mt, _ := Typify(m, time.Now().UTC())
if mt != Delegation {
t.Errorf("message is wrongly typified, expected Delegation, got %s", mt)
t.Errorf("Message is wrongly typified, expected Delegation, got %s", mt)
}
}
@ -32,19 +32,19 @@ func TestTypifyRRSIG(t *testing.T) {
m := delegationMsgRRSIGOK()
if mt, _ := Typify(m, utc); mt != Delegation {
t.Errorf("message is wrongly typified, expected Delegation, got %s", mt)
t.Errorf("Message is wrongly typified, expected Delegation, got %s", mt)
}
// Still a Delegation because EDNS0 OPT DO bool is not set, so we won't check the sigs.
m = delegationMsgRRSIGFail()
if mt, _ := Typify(m, utc); mt != Delegation {
t.Errorf("message is wrongly typified, expected Delegation, got %s", mt)
t.Errorf("Message is wrongly typified, expected Delegation, got %s", mt)
}
m = delegationMsgRRSIGFail()
m = addOpt(m)
if mt, _ := Typify(m, utc); mt != OtherError {
t.Errorf("message is wrongly typified, expected OtherError, got %s", mt)
t.Errorf("Message is wrongly typified, expected OtherError, got %s", mt)
}
}