TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

presubmit: Check errorf as well (#1845)

Browse source 
Uppercase all these test errors as well. And extend the presubmit to
check for these in the future. Also do a slightly smarter grep to only
get t.<something>. as (because dump regexp) this also grep over non test
files.
This commit is contained in:
Miek Gieben 2018-06-02 19:48:39 +01:00 • committed by Yong Tang
parent 3994d3a5a7
commit 22c0b30d5f
19 changed files with 57 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

6
plugin/pkg/singleflight/singleflight_test.go
View file

@ -48,7 +48,7 @@ func TestDoErr(t *testing.T) {
t.Errorf("Do error = %v; want someErr", err)
}
if v != nil {
t.Errorf("unexpected non-nil value %#v", v)
t.Errorf("Unexpected non-nil value %#v", v)
}
}
@ -71,7 +71,7 @@ func TestDoDupSuppress(t *testing.T) {
t.Errorf("Do error: %v", err)
}
if v.(string) != "bar" {
t.Errorf("got %q; want %q", v, "bar")
t.Errorf("Got %q; want %q", v, "bar")
}
wg.Done()
}()
@ -80,6 +80,6 @@ func TestDoDupSuppress(t *testing.T) {
c <- "bar"
wg.Wait()
if got := atomic.LoadInt32(&calls); got != 1 {
t.Errorf("number of calls = %d; want 1", got)
t.Errorf("Number of calls = %d; want 1", got)
}
}