Move to CODEOWNERS (#3489)

* Move to CODEOWNERS

No change in who own what; just a move to CODEOWNERS. This allows
dreck cleanups.

Added .dreck.yaml for alias and exec.

Fixes: #3486

Signed-off-by: Miek Gieben <miek@miek.nl>

* stickler bot

Signed-off-by: Miek Gieben <miek@miek.nl>

* sort the file

Signed-off-by: Miek Gieben <miek@miek.nl>

.dreck.yaml

@@ -0,0 +1,11 @@
+features:
+  - aliases
+  - exec
+
+aliases:
+  - |
+    /plugin (.*) -> /label plugin/$1
+  - |
+    /wai -> /label works as intended
+  - |
+    /release (.*) -> /exec /opt/bin/release-coredns $1

CODEOWNERS

@@ -0,0 +1,44 @@
+# @miekg, miek@miek.nl, project lead: 11/11/2020
+
+*                       @bradbeam @chrisohaver @dilyevsky @fastest963 @greenpau @grobie @isolus @johnbelamaric @miekg @pmoroney @rajansandeep @stp-ip @superq @yongtang
+
+/plugin/acl/            @miekg @ihac
+/plugin/any/            @miekg
+/plugin/auto/           @miekg @stp-ip
+/plugin/autopath/       @chrisohaver @miekg
+/plugin/azure/          @miekg @yongtang @darshanime
+/plugin/bind/           @miekg
+/plugin/bufsize/        @ykhr53
+/plugin/cache/          @grobie @miekg
+/plugin/cancel/         @miekg
+/plugin/chaos/          @miekg
+/plugin/clouddns/       @miekg @yongtang
+/plugin/dnssec/         @isolus @miekg
+/plugin/dnstap/         @varyoo @yongtang
+/plugin/erratic/        @miekg
+/plugin/errors/         @miekg
+/plugin/etcd/           @miekg @nitisht
+/plugin/file/           @miekg @yongtang @stp-ip
+/plugin/forward/        @grobie @johnbelamaric @miekg @rdrozhdzh
+/plugin/grpc/           @inigohu @miekg
+/plugin/health/         @fastest963 @miekg
+/plugin/hosts/          @johnbelamaric @pmoroney
+/plugin/k8s_external/   @miekg
+/plugin/kubernetes/     @bradbeam @chrisohaver @johnbelamaric @miekg @rajansandeep @yongtang
+/plugin/loadbalance/    @miekg
+/plugin/log/            @miekg @nchrisdk
+/plugin/loop/           @miekg @chrisohaver
+/plugin/metadata/       @ekleiner @miekg
+/plugin/metrics/        @fastest963 @miekg @superq @greenpau
+/plugin/nsid/           @yongtang
+/plugin/pprof/          @miekg
+/plugin/reload/         @johnbelamaric
+/plugin/rewrite/        @greenpau @johnbelamaric
+/plugin/root/           @miekg
+/plugin/route53/        @yongtang @dilyevsky
+/plugin/secondary/      @bradbeam @miekg
+/plugin/template/       @rtreffer
+/plugin/tls/            @johnbelamaric
+/plugin/trace/          @johnbelamaric
+/plugin/transfer/       @miekg @chrisohaver
+/plugin/whoami/         @miekg @chrisohaver

OWNERS

@@ -1,32 +0,0 @@
-approvers:
-  - bradbeam
-  - chrisohaver    # Infoblox | cohaver@infoblox.com
-  - dilyevsky
-  - fastest963
-  - greenpau
-  - grobie
-  - isolus
-  - johnbelamaric
-  - miekg          # miek@miek.nl | project lead: 11/11/2020
-  - pmoroney
-  - rajansandeep
-  - stp-ip
-  - superq
-  - yongtang
-
-features:
-  - comments
-  - reviewers
-  - aliases
-  - branches
-  - exec
-
-aliases:
-  - |
-    /plugin: (.*) -> /label add: plugin/$1
-  - |
-    /approve -> /lgtm
-  - |
-    /wai -> /label add: works as intended
-  - |
-    /release: (.*) -> /exec: /opt/bin/release-coredns $1

owners_generate.go

@@ -5,58 +5,29 @@
 package main
 
 import (
+	"bufio"
 	"fmt"
 	"io/ioutil"
 	"log"
 	"os"
-	"path"
-	"path/filepath"
 	"sort"
-
+	"strings"
-	"gopkg.in/yaml.v2"
 )
 
 func main() {
-	o := map[string]struct{}{}
-
 	// top-level OWNERS file
-	o, err := owners("OWNERS", o)
+	o, err := owners("CODEOWNERS")
 	if err != nil {
 		log.Fatal(err)
 	}
 
-	// each of the plugins, in case someone is not in the top-level one
-	err = filepath.Walk("plugin",
-		func(p string, i os.FileInfo, err error) error {
-			if err != nil {
-				return err
-			}
-			if i.IsDir() {
-				return nil
-			}
-			if path.Base(p) != "OWNERS" {
-				return nil
-			}
-			o, err = owners(p, o)
-			return err
-		})
-	if err != nil {
-		log.Fatal(err)
-	}
-
-	// sort it and format it
-	list := []string{}
-	for k := range o {
-		list = append(list, k)
-	}
-	sort.Strings(list)
 	golist := `package chaos
 
 // Owners are all GitHub handlers of all maintainers.
 var Owners = []string{`
 	c := ", "
-	for i, a := range list {
+	for i, a := range o {
-		if i == len(list)-1 {
+		if i == len(o)-1 {
 			c = "}"
 		}
 		golist += fmt.Sprintf("%q%s", a, c)
@@ -70,27 +41,50 @@ var Owners = []string{`
 	return
 }
 
-// owners parses a owner file without knowing a whole lot about its structure.
+func owners(path string) ([]string, error) {
-func owners(path string, owners map[string]struct{}) (map[string]struct{}, error) {
+	// simple line, by line based format
-	file, err := ioutil.ReadFile(path)
+	//
+	// # In this example, @doctocat owns any files in the build/logs
+	// # directory at the root of the repository and any of its
+	// # subdirectories.
+	// /build/logs/ @doctocat
+	f, err := os.Open(path)
 	if err != nil {
 		return nil, err
 	}
-	c := yaml.MapSlice{}
+	scanner := bufio.NewScanner(f)
-	err = yaml.Unmarshal(file, &c)
+	users := map[string]struct{}{}
-	if err != nil {
+	for scanner.Scan() {
-		return nil, err
+		text := scanner.Text()
-	}
+		if len(text) == 0 {
-	for _, mi := range c {
-		key, ok := mi.Key.(string)
-		if !ok {
 			continue
 		}
-		if key == "approvers" {
+		if text[0] == '#' {
-			for _, k := range mi.Value.([]interface{}) {
+			continue
-				owners[k.(string)] = struct{}{}
+		}
+		ele := strings.Fields(text)
+		if len(ele) == 0 {
+			continue
+		}
+
+		// ok ele[0] is the path, the rest are (in our case) github usernames prefixed with @
+		for _, s := range ele[1:] {
+			if len(s) <= 1 {
+				continue
 			}
+			users[s[1:]] = struct{}{}
 		}
 	}
-	return owners, nil
+	if err := scanner.Err(); err != nil {
+		return nil, err
+	}
+	u := []string{}
+	for k := range users {
+		if strings.HasPrefix(k, "@") {
+			k = k[1:]
+		}
+		u = append(u, k)
+	}
+	sort.Strings(u)
+	return u, nil
 }

plugin/acl/OWNERS

@@ -1,6 +0,0 @@
-reviewers:
-  - miekg
-  - ihac
-approvers:
-  - miekg
-  - ihac

plugin/any/OWNERS

@@ -1,4 +0,0 @@
-reviewers:
-  - miekg
-approvers:
-  - miekg

plugin/auto/OWNERS

@@ -1,5 +0,0 @@
-reviewers:
-  - miekg
-  - stp-ip
-approvers:
-  - miekg

plugin/autopath/OWNERS

@@ -1,6 +0,0 @@
-reviewers:
-  - chrisohaver
-  - miekg
-approvers:
-  - chrisohaver
-  - miekg

plugin/azure/OWNERS

@@ -1,8 +0,0 @@
-reviewers:
-  - miekg
-  - yongtang
-  - darshanime
-approvers:
-  - miekg
-  - yongtang
-  - darshanime

plugin/bind/OWNERS

@@ -1,4 +0,0 @@
-reviewers:
-  - miekg
-approvers:
-  - miekg

plugin/bufsize/OWNERS

@@ -1,4 +0,0 @@
-reviewers:
-  - ykhr53
-approvers:
-  - ykhr53

plugin/cache/OWNERS

@@ -1,6 +0,0 @@
-reviewers:
-  - grobie
-  - miekg
-approvers:
-  - grobie
-  - miekg

plugin/cancel/OWNERS

@@ -1,4 +0,0 @@
-reviewers:
-  - miekg
-approvers:
-  - miekg

plugin/chaos/OWNERS

@@ -1,4 +0,0 @@
-reviewers:
-  - miekg
-approvers:
-  - miekg

plugin/clouddns/OWNERS

@@ -1,6 +0,0 @@
-reviewers:
-  - miekg
-  - yongtang
-approvers:
-  - miekg
-  - yongtang

plugin/dnssec/OWNERS

@@ -1,6 +0,0 @@
-reviewers:
-  - isolus
-  - miekg
-approvers:
-  - isolus
-  - miekg

plugin/dnstap/OWNERS

@@ -1,6 +0,0 @@
-reviewers:
-  - varyoo
-  - yongtang
-approvers:
-  - varyoo
-  - yongtang

plugin/erratic/OWNERS

@@ -1,4 +0,0 @@
-reviewers:
-  - miekg
-approvers:
-  - miekg

plugin/errors/OWNERS

@@ -1,4 +0,0 @@
-reviewers:
-  - miekg
-approvers:
-  - miekg

plugin/etcd/OWNERS

@@ -1,6 +0,0 @@
-reviewers:
-  - miekg
-  - nitisht
-approvers:
-  - miekg
-  - nitisht

plugin/file/OWNERS

@@ -1,7 +0,0 @@
-reviewers:
-  - miekg
-  - yongtang
-  - stp-ip
-approvers:
-  - miekg
-  - yongtang

plugin/forward/OWNERS

@@ -1,10 +0,0 @@
-reviewers:
-  - grobie
-  - johnbelamaric
-  - miekg
-  - rdrozhdzh
-approvers:
-  - grobie
-  - johnbelamaric
-  - rdrozhdzh
-  - miekg

plugin/grpc/OWNERS

@@ -1,6 +0,0 @@
-reviewers:
-  - inigohu
-  - miekg
-approvers:
-  - inigohu
-  - miekg

plugin/health/OWNERS

@@ -1,6 +0,0 @@
-reviewers:
-  - fastest963
-  - miekg
-approvers:
-  - fastest963
-  - miekg

plugin/hosts/OWNERS

@@ -1,6 +0,0 @@
-reviewers:
-  - johnbelamaric
-  - pmoroney
-approvers:
-  - johnbelamaric
-  - pmoroney

plugin/k8s_external/OWNERS

@@ -1,4 +0,0 @@
-reviewers:
-  - miekg
-approvers:
-  - miekg

plugin/kubernetes/OWNERS

@@ -1,14 +0,0 @@
-reviewers:
-  - bradbeam
-  - chrisohaver
-  - johnbelamaric
-  - miekg
-  - rajansandeep
-  - yongtang
-approvers:
-  - bradbeam
-  - chrisohaver
-  - johnbelamaric
-  - miekg
-  - rajansandeep
-  - yongtang

plugin/loadbalance/OWNERS

@@ -1,4 +0,0 @@
-reviewers:
-  - miekg
-approvers:
-  - miekg

plugin/log/OWNERS

@@ -1,6 +0,0 @@
-reviewers:
-  - miekg
-  - nchrisdk
-approvers:
-  - miekg
-  - nchrisdk

plugin/loop/OWNERS

@@ -1,6 +0,0 @@
-reviewers:
-  - miekg
-  - chrisohaver
-approvers:
-  - miekg
-  - chrisohaver

plugin/metadata/OWNERS

@@ -1,6 +0,0 @@
-reviewers:
-  - ekleiner
-  - miekg
-approvers:
-  - ekleiner
-  - miekg

plugin/metrics/OWNERS

@@ -1,9 +0,0 @@
-reviewers:
-  - fastest963
-  - miekg
-  - superq
-  - greenpau
-approvers:
-  - fastest963
-  - miekg
-  - superq

plugin/nsid/OWNERS

@@ -1,4 +0,0 @@
-reviewers:
-  - yongtang
-approvers:
-  - yongtang

plugin/pprof/OWNERS

@@ -1,4 +0,0 @@
-reviewers:
-  - miekg
-approvers:
-  - miekg

plugin/reload/OWNERS

@@ -1,4 +0,0 @@
-reviewers:
-  - johnbelamaric
-approvers:
-  - johnbelamaric

plugin/rewrite/OWNERS

@@ -1,6 +0,0 @@
-reviewers:
-  - greenpau
-  - johnbelamaric
-approvers:
-  - greenpau
-  - johnbelamaric

plugin/root/OWNERS

@@ -1,4 +0,0 @@
-reviewers:
-  - miekg
-approvers:
-  - miekg

plugin/route53/OWNERS

@@ -1,6 +0,0 @@
-reviewers:
-  - yongtang
-  - dilyevsky
-approvers:
-  - yongtang
-  - dilyevsky

plugin/secondary/OWNERS

@@ -1,6 +0,0 @@
-reviewers:
-  - bradbeam
-  - miekg
-approvers:
-  - bradbeam
-  - miekg

plugin/template/OWNERS

@@ -1,4 +0,0 @@
-reviewers:
-  - rtreffer
-approvers:
-  - rtreffer

plugin/tls/OWNERS

@@ -1,4 +0,0 @@
-reviewers:
-  - johnbelamaric
-approvers:
-  - johnbelamaric

plugin/trace/OWNERS

@@ -1,4 +0,0 @@
-reviewers:
-  - johnbelamaric
-approvers:
-  - johnbelamaric

plugin/transfer/OWNERS

@@ -1,6 +0,0 @@
-reviewers:
-  - miekg
-  - chrisohaver
-approvers:
-  - miekg
-  - chrisohaver

plugin/whoami/OWNERS

@@ -1,6 +0,0 @@
-reviewers:
-  - miekg
-  - chrisohaver
-approvers:
-  - miekg
-  - chrisohaver