TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

goreport card fixes (#4139)

Browse source 
This fixes some inefassign as report by Go report card:
https://goreportcard.com/report/github.com/coredns/coredns

Signed-off-by: Miek Gieben <miek@miek.nl>
This commit is contained in:
Miek Gieben 2020-09-22 09:22:00 +02:00 • committed by GitHub
parent aa82ca62fb
commit 24e668ecf0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
plugin/kubernetes/informer_test.go
View file

@ -83,7 +83,7 @@ func testProcessor(t *testing.T, processor cache.ProcessFunc, idx cache.Indexer)
if err != nil { if err != nil {
t.Fatalf("delete test failed: %v", err) t.Fatalf("delete test failed: %v", err)
} }
got, exists, err = idx.Get(obj2) _, exists, err = idx.Get(obj2)
if err != nil { if err != nil {
t.Fatalf("get deleted object failed: %v", err) t.Fatalf("get deleted object failed: %v", err)
} }
@ -101,7 +101,7 @@ func testProcessor(t *testing.T, processor cache.ProcessFunc, idx cache.Indexer)
if err != nil { if err != nil {
t.Fatalf("tombstone delete test failed: %v", err) t.Fatalf("tombstone delete test failed: %v", err)
} }
got, exists, err = idx.Get(svc) _, exists, err = idx.Get(svc)
if err != nil { if err != nil {
t.Fatalf("get tombstone deleted object failed: %v", err) t.Fatalf("get tombstone deleted object failed: %v", err)
} }

2
plugin/test/helpers.go
View file

@ -248,7 +248,7 @@ func Section(tc Case, sec sect, rr []dns.RR) error {
return nil return nil
} }
// CNAMEOrder makes sure that CNAMES do not appear after their target records // CNAMEOrder makes sure that CNAMES do not appear after their target records.
func CNAMEOrder(res *dns.Msg) error { func CNAMEOrder(res *dns.Msg) error {
for i, c := range res.Answer { for i, c := range res.Answer {
if c.Header().Rrtype != dns.TypeCNAME { if c.Header().Rrtype != dns.TypeCNAME {

1
plugin/transfer/transfer.go
View file

@ -140,7 +140,6 @@ receive:
if len(rrs) > 0 { if len(rrs) > 0 {
ch <- &dns.Envelope{RR: rrs} ch <- &dns.Envelope{RR: rrs}
l += len(rrs) l += len(rrs)
rrs = []dns.RR{}
} }
if soa != nil { if soa != nil {