TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Implement deprecation notice for 1.1.4 (#1833)

Browse source 
* Implement deprecation notice for 1.1.4

This still allows all the config to be parsed, but noops it:

* -log; always set the log to stdout; no matter what.
* https_google; removed from the proxy implementation.
* reverse plugin: set to deprecated.

* Whole of reverse can go

* Remove test for deprecated plugin
This commit is contained in:
Miek Gieben 2018-05-24 14:30:01 +01:00 • committed by GitHub
parent b0fd575c65
commit 2758a756dd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
20 changed files with 9 additions and 1306 deletions
Download patch file Download diff file Expand all files Collapse all files

8
plugin/proxy/proxy.go
View file

@ -129,14 +129,6 @@ func (p Proxy) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (
}
}
// If protocol is https_google we do the health checks wrong, i.e. we're healthchecking the wrong
// endpoint, hence the health check code below should not be executed. See issue #1202.
// This is an ugly hack and the thing requires a rethink. Possibly in conjunction with moving
// to the *forward* plugin.
if upstream.Exchanger().Protocol() == "https_google" {
continue
}
timeout := host.FailTimeout
if timeout == 0 {
timeout = defaultFailTimeout