From 2aa1bda00529d6e168628c704955d132272f6436 Mon Sep 17 00:00:00 2001
From: Miek Gieben <miek@miek.nl>
Date: Tue, 3 Jul 2018 12:00:22 +0100
Subject: [PATCH] plugin/cache: add extra test for FORMERR (#1930)

* plugin/cache: add extra test for FORMERR

Add extra test that test for not caching a formerr.

Signed-off-by: Miek Gieben <miek@miek.nl>

* govet

Signed-off-by: Miek Gieben <miek@miek.nl>
---
 plugin/cache/error_test.go | 38 ++++++++++++++++++++++++++++++++++++++
 plugin/cache/spoof_test.go |  2 +-
 2 files changed, 39 insertions(+), 1 deletion(-)
 create mode 100644 plugin/cache/error_test.go

diff --git a/plugin/cache/error_test.go b/plugin/cache/error_test.go
new file mode 100644
index 000000000..7ae603e10
--- /dev/null
+++ b/plugin/cache/error_test.go
@@ -0,0 +1,38 @@
+package cache
+
+import (
+	"context"
+	"testing"
+
+	"github.com/coredns/coredns/plugin"
+	"github.com/coredns/coredns/plugin/pkg/dnstest"
+	"github.com/coredns/coredns/plugin/test"
+
+	"github.com/miekg/dns"
+)
+
+func TestFormErr(t *testing.T) {
+	c := New()
+	c.Next = formErrHandler()
+
+	req := new(dns.Msg)
+	req.SetQuestion("example.org.", dns.TypeA)
+	rec := dnstest.NewRecorder(&test.ResponseWriter{})
+
+	c.ServeDNS(context.TODO(), rec, req)
+
+	if c.pcache.Len() != 0 {
+		t.Errorf("Cached %s, while reply had %d", "example.org.", rec.Msg.Rcode)
+	}
+}
+
+// formErrHanlder is a fake plugin implementation which returns a FORMERR for a reply.
+func formErrHandler() plugin.Handler {
+	return plugin.HandlerFunc(func(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (int, error) {
+		m := new(dns.Msg)
+		m.SetQuestion("example.net.", dns.TypeA)
+		m.Rcode = dns.RcodeFormatError
+		w.WriteMsg(m)
+		return dns.RcodeSuccess, nil
+	})
+}
diff --git a/plugin/cache/spoof_test.go b/plugin/cache/spoof_test.go
index 04d714f4a..20d7e8d51 100644
--- a/plugin/cache/spoof_test.go
+++ b/plugin/cache/spoof_test.go
@@ -6,8 +6,8 @@ import (
 
 	"github.com/coredns/coredns/plugin"
 	"github.com/coredns/coredns/plugin/pkg/dnstest"
-
 	"github.com/coredns/coredns/plugin/test"
+
 	"github.com/miekg/dns"
 )