TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Startup notification (#250)

Browse source 
Stop the caddy message and start our own init notifications.
Log the version of CoreDNS when starting up.
Fix all middleware's setup functions so that return the error prefixed
with *which* middleware was failing; leads to better debuggable errors
when starting up.
This commit is contained in:
Miek Gieben 2016-09-10 09:16:25 +01:00 • committed by GitHub
parent 5216ab6b58
commit 2dd8a687b3
19 changed files with 82 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

7
middleware/errors/setup.go
View file

@ -6,6 +6,7 @@ import (
"os"
"github.com/miekg/coredns/core/dnsserver"
"github.com/miekg/coredns/middleware"
"github.com/miekg/coredns/middleware/pkg/roller"
"github.com/hashicorp/go-syslog"
@ -22,7 +23,7 @@ func init() {
func setup(c *caddy.Controller) error {
handler, err := errorsParse(c)
if err != nil {
return err
return middleware.Error("errors", err)
}
var writer io.Writer
@ -37,7 +38,7 @@ func setup(c *caddy.Controller) error {
case "syslog":
writer, err = gsyslog.NewLogger(gsyslog.LOG_ERR, "LOCAL0", "coredns")
if err != nil {
return err
return middleware.Error("errors", err)
}
default:
if handler.LogFile == "" {
@ -48,7 +49,7 @@ func setup(c *caddy.Controller) error {
var file *os.File
file, err = os.OpenFile(handler.LogFile, os.O_RDWR|os.O_CREATE|os.O_APPEND, 0644)
if err != nil {
return err
return middleware.Error("errors", err)
}
if handler.LogRoller != nil {
file.Close()