TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Various improvements in the release documention. (#1961)

Browse source 
Releasing 1.2.0 uncovered some rough edges that need to be documented.
Also fix github-push target and docker login.

Signed-off-by: Miek Gieben <miek@miek.nl>
This commit is contained in:
Miek Gieben 2018-07-11 09:56:37 +01:00 • committed by GitHub
parent 2306721c23
commit 2e322f6e8a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
Makefile.release
View file

@ -18,12 +18,15 @@
# * Send PR to get this merged. # * Send PR to get this merged.
# #
# * Open an issue for this release # * Open an issue for this release
# * In an issue give the command: /release # * In an issue give the command: /release: master
# * (to test as release /release: -t master can be used.
# #
# See coredns/release for the README on what needs to be setup for this to be automated (can still # See github.com/coredns/release for documentation README on what needs to be setup for this to be
# be done by hand if needed). Especially what environment variables need to be set! # automated (can still be done by hand if needed). Especially what environment variables need to be
# set!
# #
# To release we run: # To release we run, where 'release' and 'docker' only locally build assets; these are the same
# targets that get executed in case of testing.
# * make release # * make release
# * make github-push # * make github-push
# * make docker # * make docker
@ -84,7 +87,7 @@ tar:
done done
.PHONY: github-push .PHONY: github-push
upload: github-push:
@echo Releasing: $(VERSION) @echo Releasing: $(VERSION)
@$(eval RELEASE:=$(shell curl -s -d '{"tag_name": "v$(VERSION)", "name": "v$(VERSION)"}' "https://api.github.com/repos/$(GITHUB)/$(NAME)/releases?access_token=${GITHUB_ACCESS_TOKEN}" | grep -m 1 '"id"' | tr -cd '[[:digit:]]')) @$(eval RELEASE:=$(shell curl -s -d '{"tag_name": "v$(VERSION)", "name": "v$(VERSION)"}' "https://api.github.com/repos/$(GITHUB)/$(NAME)/releases?access_token=${GITHUB_ACCESS_TOKEN}" | grep -m 1 '"id"' | tr -cd '[[:digit:]]'))
@echo ReleaseID: $(RELEASE) @echo ReleaseID: $(RELEASE)
@ -97,10 +100,10 @@ upload:
.PHONY: docker-build .PHONY: docker-build
docker-build: tar docker-build: tar
# Steps: @# Steps:
# 1. Copy appropriate coredns binary to build/docker/linux/<arch> @# 1. Copy appropriate coredns binary to build/docker/linux/<arch>
# 2. Copy Dockerfile to build/docker/linux/<arch> @# 2. Copy Dockerfile to build/docker/linux/<arch>
rm -rf build/docker @rm -rf build/docker
for arch in $(LINUX_ARCH); do \ for arch in $(LINUX_ARCH); do \
mkdir -p build/docker/linux/$$arch ;\ mkdir -p build/docker/linux/$$arch ;\
tar -xzf release/$(NAME)_$(VERSION)_linux_$$arch.tgz -C build/docker/linux/$$arch ;\ tar -xzf release/$(NAME)_$(VERSION)_linux_$$arch.tgz -C build/docker/linux/$$arch ;\
@ -111,7 +114,7 @@ docker-build: tar
.PHONY: docker-push .PHONY: docker-push
docker-push: docker-push:
@docker -u $(DOCKER_LOGIN) -p $(DOCKER_PASSWORD) || exit 1 @echo $(DOCKER_PASSWORD) | docker login -u $(DOCKER_LOGIN) --password-stdin
@echo Pushing: $(VERSION) to $(DOCKER_IMAGE_NAME) @echo Pushing: $(VERSION) to $(DOCKER_IMAGE_NAME)
for arch in $(LINUX_ARCH); do \ for arch in $(LINUX_ARCH); do \
docker push $(DOCKER_IMAGE_NAME):coredns-$$arch ;\ docker push $(DOCKER_IMAGE_NAME):coredns-$$arch ;\
@ -119,7 +122,6 @@ docker-push:
manifest-tool push from-args --platforms $(PLATFORMS) --template $(DOCKER_IMAGE_NAME):coredns-ARCH --target $(DOCKER_IMAGE_NAME):$(VERSION) manifest-tool push from-args --platforms $(PLATFORMS) --template $(DOCKER_IMAGE_NAME):coredns-ARCH --target $(DOCKER_IMAGE_NAME):$(VERSION)
manifest-tool push from-args --platforms $(PLATFORMS) --template $(DOCKER_IMAGE_NAME):coredns-ARCH --target $(DOCKER_IMAGE_NAME):latest manifest-tool push from-args --platforms $(PLATFORMS) --template $(DOCKER_IMAGE_NAME):coredns-ARCH --target $(DOCKER_IMAGE_NAME):latest
.PHONY: clean .PHONY: clean
clean: clean:
rm -rf release rm -rf release

11
README.md
View file

@ -189,12 +189,11 @@ More resources can be found:
## Deployment ## Deployment
Examples for deployment via systemd and other use cases can be found in the Examples for deployment via systemd and other use cases can be found in the [deployment
[deployment repository](https://github.com/coredns/deployment). repository](https://github.com/coredns/deployment).
## Security ## Security
If you find a security vulnerability or any security related issues, If you find a security vulnerability or any security related issues, please DO NOT file a public
please DO NOT file a public issue, instead send your report privately to issue, instead send your report privately to `security@coredns.io`. Security reports are greatly
`security@coredns.io`. Security reports are greatly appreciated and we appreciated and we will publicly thank you for it.
will publicly thank you for it.