From 30309861c56157e38eb06c20e3bc62c1e5a818bc Mon Sep 17 00:00:00 2001 From: Francois Tur Date: Wed, 9 May 2018 10:09:06 -0400 Subject: [PATCH] - review BUG related doc for Health and Premotheus after change of behavior to be compatible with reload feature. (#1790) --- plugin/health/README.md | 7 +++++++ plugin/metrics/README.md | 6 ++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/plugin/health/README.md b/plugin/health/README.md index 5cb6c7beb..b7d4892b3 100644 --- a/plugin/health/README.md +++ b/plugin/health/README.md @@ -93,3 +93,10 @@ Set a lameduck duration of 1 second: } } ~~~ + +## Bugs + +When reloading, the Health handler is stopped before the new server instance is started. +If that new server fails to start, then the initial server instance is still available and DNS queries still served, +but Health handler stays down. +Health will not reply HTTP request until a successful reload or a complete restart of CoreDNS. diff --git a/plugin/metrics/README.md b/plugin/metrics/README.md index c962068a4..2a914fe44 100644 --- a/plugin/metrics/README.md +++ b/plugin/metrics/README.md @@ -71,5 +71,7 @@ then: ## Bugs -When reloading, we keep the handler running, meaning that any changes to the handler's address -aren't picked up. You'll need to restart CoreDNS for that to happen. +When reloading, the Prometheus handler is stopped before the new server instance is started. +If that new server fails to start, then the initial server instance is still available and DNS queries still served, +but Prometheus handler stays down. +Prometheus will not reply HTTP request until a successful reload or a complete restart of CoreDNS.