From 395be9adfc07017d8dc9a8c260aed2541b4adda3 Mon Sep 17 00:00:00 2001 From: Miek Gieben <miek@miek.nl> Date: Fri, 27 Jul 2018 15:01:27 +0100 Subject: [PATCH] Makefile: remove goimports (#2008) This downloads gometalinter (which is now breaking in the CI tests). Also the goimports target is run with ||true, so nothing will break if this flags anything (done because of gofmt changes in between release). Probably I will setup something to use github's linter API: https://github.com/markstory/lint-review Signed-off-by: Miek Gieben <miek@miek.nl> --- Makefile | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/Makefile b/Makefile index 722c58b9e..b66a6c9f4 100644 --- a/Makefile +++ b/Makefile @@ -15,7 +15,7 @@ coredns: $(CHECKS) CGO_ENABLED=0 $(SYSTEM) go build $(VERBOSE) -ldflags="-s -w -X github.com/coredns/coredns/coremain.GitCommit=$(GITCOMMIT)" -o $(BINARY) .PHONY: check -check: presubmit goimports core/zplugin.go core/dnsserver/zdirectives.go godeps +check: presubmit core/zplugin.go core/dnsserver/zdirectives.go godeps .PHONY: test test: check @@ -78,12 +78,6 @@ gen: pb: $(MAKE) -C pb -.PHONY: goimports -goimports: - go get -u github.com/alecthomas/gometalinter - gometalinter --install goimports > /dev/null - ( gometalinter --deadline=2m --disable-all --enable=goimports --enable=golint --enable=vet --vendor --exclude=^pb/ ./... || true ) - # Presubmit runs all scripts in .presubmit; any non 0 exit code will fail the build. .PHONY: presubmit presubmit: