Revert k8s changes

This commit is contained in:
Manuel de Brito Fontes 2016-09-22 08:29:50 -03:00
parent e0a49b73b5
commit 3be9e58ddf
2 changed files with 29 additions and 19 deletions

View file

@ -55,15 +55,12 @@ func newdnsController(kubeClient *client.Client, resyncPeriod time.Duration, lse
}, },
&api.Endpoints{}, resyncPeriod, cache.ResourceEventHandlerFuncs{}) &api.Endpoints{}, resyncPeriod, cache.ResourceEventHandlerFuncs{})
dns.svcLister.Indexer, dns.svcController = cache.NewIndexerInformer( dns.svcLister.Store, dns.svcController = cache.NewInformer(
&cache.ListWatch{ &cache.ListWatch{
ListFunc: serviceListFunc(dns.client, namespace, dns.selector), ListFunc: serviceListFunc(dns.client, namespace, dns.selector),
WatchFunc: serviceWatchFunc(dns.client, namespace, dns.selector), WatchFunc: serviceWatchFunc(dns.client, namespace, dns.selector),
}, },
&api.Service{}, &api.Service{}, resyncPeriod, cache.ResourceEventHandlerFuncs{})
resyncPeriod,
cache.ResourceEventHandlerFuncs{},
cache.Indexers{cache.NamespaceIndex: cache.MetaNamespaceIndexFunc})
dns.nsLister.Store, dns.nsController = cache.NewInformer( dns.nsLister.Store, dns.nsController = cache.NewInformer(
&cache.ListWatch{ &cache.ListWatch{
@ -166,34 +163,47 @@ func (dns *dnsController) GetNamespaceList() *api.NamespaceList {
return &nsList return &nsList
} }
func (dns *dnsController) GetServiceList() []*api.Service { func (dns *dnsController) GetServiceList() *api.ServiceList {
svcs, err := dns.svcLister.List(labels.Everything()) svcList, err := dns.svcLister.List()
if err != nil { if err != nil {
return []*api.Service{} return &api.ServiceList{}
} }
return svcs
return &svcList
} }
// GetServicesByNamespace returns a map of // GetServicesByNamespace returns a map of
// namespacename :: [ kubernetesService ] // namespacename :: [ kubernetesService ]
func (dns *dnsController) GetServicesByNamespace() map[string][]api.Service { func (dns *dnsController) GetServicesByNamespace() map[string][]api.Service {
k8sServiceList := dns.GetServiceList() k8sServiceList := dns.GetServiceList()
items := make(map[string][]api.Service, len(k8sServiceList)) if k8sServiceList == nil {
for _, i := range k8sServiceList { return nil
namespace := i.Namespace
items[namespace] = append(items[namespace], *i)
} }
items := make(map[string][]api.Service, len(k8sServiceList.Items))
for _, i := range k8sServiceList.Items {
namespace := i.Namespace
items[namespace] = append(items[namespace], i)
}
return items return items
} }
// GetServiceInNamespace returns the Service that matches // GetServiceInNamespace returns the Service that matches
// servicename in the namespace // servicename in the namespace
func (dns *dnsController) GetServiceInNamespace(namespace string, servicename string) *api.Service { func (dns *dnsController) GetServiceInNamespace(namespace string, servicename string) *api.Service {
svcObj, err := dns.svcLister.Services(namespace).Get(servicename) svcKey := fmt.Sprintf("%v/%v", namespace, servicename)
svcObj, svcExists, err := dns.svcLister.Store.GetByKey(svcKey)
if err != nil { if err != nil {
// TODO(...): should return err here // TODO(...): should return err here
return nil return nil
} }
return svcObj if !svcExists {
// TODO(...): should return err here
return nil
}
return svcObj.(*api.Service)
} }

View file

@ -183,14 +183,14 @@ func (k *Kubernetes) Get(namespace string, nsWildcard bool, servicename string,
var resultItems []api.Service var resultItems []api.Service
for _, item := range serviceList { for _, item := range serviceList.Items {
if symbolMatches(namespace, item.Namespace, nsWildcard) && symbolMatches(servicename, item.Name, serviceWildcard) { if symbolMatches(namespace, item.Namespace, nsWildcard) && symbolMatches(servicename, item.Name, serviceWildcard) {
// If namespace has a wildcard, filter results against Corefile namespace list. // If namespace has a wildcard, filter results against Corefile namespace list.
// (Namespaces without a wildcard were filtered before the call to this function.) // (Namespaces without a wildcard were filtered before the call to this function.)
if nsWildcard && (len(k.Namespaces) > 0) && (!util.StringInSlice(item.Namespace, k.Namespaces)) { if nsWildcard && (len(k.Namespaces) > 0) && (!util.StringInSlice(item.Namespace, k.Namespaces)) {
continue continue
} }
resultItems = append(resultItems, *item) resultItems = append(resultItems, item)
} }
} }
@ -216,11 +216,11 @@ func isKubernetesNameError(err error) bool {
} }
func (k *Kubernetes) getServiceRecordForIP(ip, name string) []msg.Service { func (k *Kubernetes) getServiceRecordForIP(ip, name string) []msg.Service {
svcList, err := k.APIConn.svcLister.List(labels.Everything()) svcList, err := k.APIConn.svcLister.List()
if err != nil { if err != nil {
return nil return nil
} }
for _, service := range svcList { for _, service := range svcList.Items {
if service.Spec.ClusterIP == ip { if service.Spec.ClusterIP == ip {
return []msg.Service{msg.Service{Host: ip}} return []msg.Service{msg.Service{Host: ip}}
} }