From 41f9142dd29a09bba93aa85a018c55ecfbd51496 Mon Sep 17 00:00:00 2001
From: Zou Nengren <zounengren@cmss.chinamobile.com>
Date: Wed, 1 Jul 2020 16:17:26 +0800
Subject: [PATCH] complete nsid plugin test case (#3981)

Signed-off-by: zounengren <zounengren@cmss.chinamobile.com>
---
 plugin/nsid/nsid_test.go  |  2 +-
 plugin/nsid/setup_test.go | 16 ++++++++++++++++
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/plugin/nsid/nsid_test.go b/plugin/nsid/nsid_test.go
index 04c21fa0a..eda45302e 100644
--- a/plugin/nsid/nsid_test.go
+++ b/plugin/nsid/nsid_test.go
@@ -57,7 +57,7 @@ func TestNsid(t *testing.T) {
 		if err != tc.expectedErr {
 			t.Errorf("Test %d: Expected error %v, but got %v", i, tc.expectedErr, err)
 		}
-		if code != int(tc.expectedCode) {
+		if code != tc.expectedCode {
 			t.Errorf("Test %d: Expected status code %d, but got %d", i, tc.expectedCode, code)
 		}
 		if tc.expectedReply != "" {
diff --git a/plugin/nsid/setup_test.go b/plugin/nsid/setup_test.go
index 62a27fca2..bf5998815 100644
--- a/plugin/nsid/setup_test.go
+++ b/plugin/nsid/setup_test.go
@@ -26,6 +26,22 @@ func TestSetupNsid(t *testing.T) {
 		{`nsid
 		nsid`, true, "", "plugin"},
 	}
+	for i, test := range tests {
+		c := caddy.NewTestController("dns", test.input)
+		err := setup(c)
+		if test.shouldErr && err == nil {
+			t.Errorf("Test %d: Expected error but found %s for input %s", i, err, test.input)
+		}
+		if err != nil {
+			if !test.shouldErr {
+				t.Errorf("Test %d: Expected no error but found one for input %s. Error was: %v", i, test.input, err)
+			}
+
+			if !strings.Contains(err.Error(), test.expectedErrContent) {
+				t.Errorf("Test %d: Expected error to contain: %v, found error: %v, input: %s", i, test.expectedErrContent, err, test.input)
+			}
+		}
+	}
 
 	for i, test := range tests {
 		c := caddy.NewTestController("dns", test.input)