TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 4 Projects Releases Packages Wiki Activity Actions

Correct some if/iff mixups (#3406)

Browse source 
This is a fixup for https://github.com/coredns/coredns/pull/3310 which
replaced some 'iff's with 'if' under the assumption they were typos.

I'm fairly confident they were "If and only if"
(https://en.wikipedia.org/wiki/If_and_only_if), which is commonly
shortened as "iff".

I've updated them to the full length 'if, and only if' for the sake of
readability.

Signed-off-by: Euan Kemp <euan@ngrok.com>
This commit is contained in:
Euan Kemp 2019-10-29 06:38:56 -07:00 • committed by Chris O'Haver
parent 1821d9cb7e
commit 431c70e8b9
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
plugin/autopath/autopath.go
View file

@ -5,7 +5,7 @@ client's search path resolution by performing these lookups on the server...
The server has a copy (via AutoPathFunc) of the client's search path and on The server has a copy (via AutoPathFunc) of the client's search path and on
receiving a query it first establishes if the suffix matches the FIRST configured receiving a query it first establishes if the suffix matches the FIRST configured
element. If no match can be found the query will be forwarded up the plugin element. If no match can be found the query will be forwarded up the plugin
chain without interference (if 'fallthrough' has been set). chain without interference (if, and only if, 'fallthrough' has been set).
If the query is deemed to fall in the search path the server will perform the If the query is deemed to fall in the search path the server will perform the
queries with each element of the search path appended in sequence until a queries with each element of the search path appended in sequence until a

4
plugin/dnssec/dnskey.go
View file

@ -83,12 +83,12 @@ func (d Dnssec) getDNSKEY(state request.Request, zone string, do bool, server st
return m return m
} }
// Return true if this is a zone key with the SEP bit unset. This implies a ZSK (rfc4034 2.1.1). // Return true if, and only if, this is a zone key with the SEP bit unset. This implies a ZSK (rfc4034 2.1.1).
func (k DNSKEY) isZSK() bool { func (k DNSKEY) isZSK() bool {
return k.K.Flags&(1<<8) == (1<<8) && k.K.Flags&1 == 0 return k.K.Flags&(1<<8) == (1<<8) && k.K.Flags&1 == 0
} }
// Return true if this is a zone key with the SEP bit set. This implies a KSK (rfc4034 2.1.1). // Return true if, and only if, this is a zone key with the SEP bit set. This implies a KSK (rfc4034 2.1.1).
func (k DNSKEY) isKSK() bool { func (k DNSKEY) isKSK() bool {
return k.K.Flags&(1<<8) == (1<<8) && k.K.Flags&1 == 1 return k.K.Flags&(1<<8) == (1<<8) && k.K.Flags&1 == 1
} }