TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

fix: clouddns plugin answers limited to one response (#5986)

Browse source 
* inserts all records in the loop. checks for insert errors. adds test. fixes #5985

Signed-off-by: Marcos Mendez <marcos_mendez@homedepot.com>
This commit is contained in:
Marcos Mendez 2023-03-23 11:34:11 -04:00 • committed by GitHub
parent c2d56581b5
commit 48c40ae1cd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 23 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
plugin/clouddns/clouddns.go
View file

@ -161,16 +161,18 @@ func updateZoneFromRRS(rrs *gcp.ResourceRecordSetsListResponse, z *file.Zone) er
if rr.Type == "CNAME" || rr.Type == "PTR" {
value = dns.Fqdn(value)
}
// Assemble RFC 1035 conforming record to pass into dns scanner.
rfc1035 = fmt.Sprintf("%s %d IN %s %s", dns.Fqdn(rr.Name), rr.Ttl, rr.Type, value)
r, err = dns.NewRR(rfc1035)
if err != nil {
return fmt.Errorf("failed to parse resource record: %v", err)
}
}
z.Insert(r)
err = z.Insert(r)
if err != nil {
return fmt.Errorf("failed to insert record: %v", err)
}
}
}
return nil
}