TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

fix: clouddns plugin answers limited to one response (#5986)

Browse source 
* inserts all records in the loop. checks for insert errors. adds test. fixes #5985

Signed-off-by: Marcos Mendez <marcos_mendez@homedepot.com>
This commit is contained in:
Marcos Mendez 2023-03-23 11:34:11 -04:00 • committed by GitHub
parent c2d56581b5
commit 48c40ae1cd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 23 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

18
plugin/clouddns/clouddns_test.go
View file

@ -114,6 +114,15 @@ func (c fakeGCPClient) listRRSets(ctx context.Context, projectName, hostedZoneNa
Type: "SOA",
Rrdatas: []string{"ns-cloud-e1.googledomains.com. cloud-dns-hostmaster.google.com. 1 21600 300 259200 300"},
},
{
Name: "_dummy._tcp.example.org.",
Ttl: 300,
Type: "SRV",
Rrdatas: []string{
"0 0 5269 split-example.org",
"0 0 5269 other-example.org",
},
},
}
}
@ -262,6 +271,15 @@ func TestCloudDNS(t *testing.T) {
"www.example.org. 300 IN A 1.2.3.4",
},
},
// 13. example.org SRV found with 2 answers - success.
{
qname: "_dummy._tcp.example.org.",
qtype: dns.TypeSRV,
wantAnswer: []string{
"_dummy._tcp.example.org. 300 IN SRV 0 0 5269 split-example.org.",
"_dummy._tcp.example.org. 300 IN SRV 0 0 5269 other-example.org.",
},
},
}
for ti, tc := range tests {