TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

plugin/cache: Set min TTL default to zero (#2199)

Browse source 
* set min ttl default to zero

* add short TTL test case
This commit is contained in:
Chris O'Haver 2018-10-16 09:24:40 -04:00 • committed by Yong Tang
parent 8cc8afa96a
commit 4a5641c379
4 changed files with 22 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

23
test/cache_test.go
View file

@ -43,17 +43,28 @@ func TestLookupCache(t *testing.T) {
p := proxy.NewLookup([]string{udp})
state := request.Request{W: &test.ResponseWriter{}, Req: new(dns.Msg)}
resp, err := p.Lookup(state, "example.org.", dns.TypeA)
t.Run("Long TTL", func(t *testing.T) {
testCase(t, state, p, "example.org.", 2, 10)
})
t.Run("Short TTL", func(t *testing.T) {
testCase(t, state, p, "short.example.org.", 1, 1)
})
}
func testCase(t *testing.T, state request.Request, p proxy.Proxy, name string, expectAnsLen int, expectTTL uint32) {
resp, err := p.Lookup(state, name, dns.TypeA)
if err != nil {
t.Fatal("Expected to receive reply, but didn't")
}
// expect answer section with A record in it
if len(resp.Answer) == 0 {
t.Fatal("Expected to at least one RR in the answer section, got none")
if len(resp.Answer) != expectAnsLen {
t.Fatalf("Expected %v RR in the answer section, got %v.", expectAnsLen, len(resp.Answer))
}
ttl := resp.Answer[0].Header().Ttl
if ttl != 10 { // as set in the Corefile
t.Errorf("Expected TTL to be %d, got %d", 10, ttl)
if ttl != expectTTL {
t.Errorf("Expected TTL to be %d, got %d", expectTTL, ttl)
}
}