TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Add k8s tags to related tests (#1018)

Browse source 
, so that `make test` will pass by default.

Also fixed several ineffassign and golint issues.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
This commit is contained in:
Yong Tang 2017-09-01 10:21:05 -07:00 • committed by Miek Gieben
parent 6493858893
commit 4b14243e9b
7 changed files with 19 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

12
middleware/dnstap/out/tcp_test.go
View file

@ -5,7 +5,7 @@ import (
"testing"
)
func sendOneTcp(tcp *TCP) error {
func sendOneTCP(tcp *TCP) error {
if _, err := tcp.Write([]byte("frame")); err != nil {
return err
}
@ -14,10 +14,10 @@ func sendOneTcp(tcp *TCP) error {
}
return nil
}
func TestTcp(t *testing.T) {
func TestTCP(t *testing.T) {
tcp := NewTCP("localhost:14000")
if err := sendOneTcp(tcp); err == nil {
if err := sendOneTCP(tcp); err == nil {
t.Fatal("Not listening but no error.")
return
}
@ -34,7 +34,7 @@ func TestTcp(t *testing.T) {
wait <- true
}()
if err := sendOneTcp(tcp); err != nil {
if err := sendOneTCP(tcp); err != nil {
t.Fatalf("send one: %s", err)
return
}
@ -44,7 +44,7 @@ func TestTcp(t *testing.T) {
// TODO: When the server isn't responding according to the framestream protocol
// the thread is blocked.
/*
if err := sendOneTcp(tcp); err == nil {
if err := sendOneTCP(tcp); err == nil {
panic("must fail")
}
*/
@ -54,7 +54,7 @@ func TestTcp(t *testing.T) {
wait <- true
}()
if err := sendOneTcp(tcp); err != nil {
if err := sendOneTCP(tcp); err != nil {
t.Fatalf("send one: %s", err)
return
}