TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 4 Projects Releases Packages Wiki Activity Actions

middleware/proxy: drop protcol in metric

Browse source 
This blows up prometheus (panic in CoreDNS) and is not that
handy to have.
This commit is contained in:
Miek Gieben 2017-01-18 20:33:18 +00:00
parent 7c45f0227a
commit 51a34d934d
2 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
middleware/proxy/README.md
View file

@ -60,11 +60,10 @@ Currently supported are `dns` (i.e., standard DNS over UDP) and `https_google`.
If monitoring is enabled (via the *prometheus* directive) then the following metric is exported: If monitoring is enabled (via the *prometheus* directive) then the following metric is exported:
* coredns_proxy_request_count_total{protocol, zone, family} * coredns_proxy_request_duration_milliseconds{zone}
This has some overlap with `coredns_dns_request_count_total{zone, proto, family}`, but allows for The metric shows the duration for a proxied request, the `zone` label is the **FROM** as specified
specifics on upstream query resolving. See the *prometheus* documentation for more details. in the configuration.
`protocol` is the protocol used to query the upstream.
## Examples ## Examples

2
middleware/proxy/metrics.go
View file

@ -16,7 +16,7 @@ var (
Name: "request_duration_milliseconds", Name: "request_duration_milliseconds",
Buckets: append(prometheus.DefBuckets, []float64{50, 100, 200, 500, 1000, 2000, 3000, 4000, 5000, 10000}...), Buckets: append(prometheus.DefBuckets, []float64{50, 100, 200, 500, 1000, 2000, 3000, 4000, 5000, 10000}...),
Help: "Histogram of the time (in milliseconds) each request took.", Help: "Histogram of the time (in milliseconds) each request took.",
}, []string{"protocol", "zone"}) }, []string{"zone"})
) )
// OnStartup sets up the metrics on startup. This is done for all proxy protocols. // OnStartup sets up the metrics on startup. This is done for all proxy protocols.