TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Change default value to 1232 (#6183)

Browse source 
* Change default value to 1232

As specified by DNS flag day 2020, good and decent default value
avoiding fragmentation issues should be 1232. It is quite likely 1500
would work reliably on local ethernet networks.

Value 512 is set implicitly and must be used for all clients, which did
not include OPT RR with explicit value they support.

Since MR #5368 it should work correctly.

Signed-off-by: Petr Menšík <pemensik@redhat.com>

* Adapt bufsize test to new default value

Check also buffer size smaller than legacy value is not accepted.

Signed-off-by: Petr Menšík <pemensik@redhat.com>

* Update bufsize documentation

Mention also increasing request size is not possible, it can only reduce
the accepted size.

Signed-off-by: Petr Menšík <pemensik@redhat.com>

---------

Signed-off-by: Petr Menšík <pemensik@redhat.com>
This commit is contained in:
Petr Menšík 2023-07-10 16:49:52 +02:00 • committed by GitHub
parent 7569d132a1
commit 52f0348312
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 16 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

5
plugin/bufsize/setup.go
View file

@ -24,12 +24,13 @@ func setup(c *caddy.Controller) error {
}
func parse(c *caddy.Controller) (int, error) {
const defaultBufSize = 512
// value from http://www.dnsflagday.net/2020/
const defaultBufSize = 1232
for c.Next() {
args := c.RemainingArgs()
switch len(args) {
case 0:
// Nothing specified; use 512 as default
// Nothing specified; use defaultBufSize
return defaultBufSize, nil
case 1:
// Specified value is needed to verify