Fix obsure crash in Corefile parsing (#4637)
This was found by fuzzing. We need to make this a fully qualified domain name to catch all errors in dnsserver/register.go and not later when plugin.Normalize() is called again on these strings, with the prime difference being that the domain name is fully qualified. This was found by fuzzing where "ȶ" is deemed OK, but "ȶ." is not (might be a bug in miekg/dns actually). But here we were checking ȶ, which is OK, and later we barf in ȶ. leading to "index out of range". Added a tests and check manually if it would crash with the current code (yes), and fail with an error in this PR (yes). Signed-off-by: Miek Gieben <miek@miek.nl>
This commit is contained in:
parent
df736adbc8
commit
5d80a6e21e
3 changed files with 33 additions and 1 deletions
17
test/corefile_test.go
Normal file
17
test/corefile_test.go
Normal file
|
@ -0,0 +1,17 @@
|
|||
package test
|
||||
|
||||
import (
|
||||
"testing"
|
||||
)
|
||||
|
||||
func TestCorefile1(t *testing.T) {
|
||||
corefile := `ȶ
|
||||
acl
|
||||
`
|
||||
// this crashed, now it should return an error.
|
||||
i, _, _, err := CoreDNSServerAndPorts(corefile)
|
||||
if err == nil {
|
||||
defer i.Stop()
|
||||
t.Fatalf("Expected an error got none")
|
||||
}
|
||||
}
|
Loading…
Add table
Add a link
Reference in a new issue