diff --git a/plugin/kubernetes/handler_test.go b/plugin/kubernetes/handler_test.go index c9df46d07..6bcb00ecd 100644 --- a/plugin/kubernetes/handler_test.go +++ b/plugin/kubernetes/handler_test.go @@ -288,6 +288,7 @@ var svcIndex = map[string][]*api.Service{ Protocol: "tcp", Port: 80, }}, + Type: api.ServiceTypeExternalName, }, }}, } diff --git a/plugin/kubernetes/kubernetes.go b/plugin/kubernetes/kubernetes.go index d8b27d42d..8048f85cb 100644 --- a/plugin/kubernetes/kubernetes.go +++ b/plugin/kubernetes/kubernetes.go @@ -418,16 +418,15 @@ func (k *Kubernetes) findServices(r recordRequest, zone string) (services []msg. } // External service - if svc.Spec.ExternalName != "" { + if svc.Spec.Type == api.ServiceTypeExternalName { s := msg.Service{Key: strings.Join([]string{zonePath, Svc, svc.Namespace, svc.Name}, "/"), Host: svc.Spec.ExternalName, TTL: k.ttl} if t, _ := s.HostType(); t == dns.TypeCNAME { s.Key = strings.Join([]string{zonePath, Svc, svc.Namespace, svc.Name}, "/") services = append(services, s) err = nil - - continue } + continue } // ClusterIP service diff --git a/plugin/kubernetes/kubernetes_test.go b/plugin/kubernetes/kubernetes_test.go index f05693d71..6a95c5b71 100644 --- a/plugin/kubernetes/kubernetes_test.go +++ b/plugin/kubernetes/kubernetes_test.go @@ -101,6 +101,7 @@ func (APIConnServiceTest) SvcIndex(string) []*api.Service { Protocol: "tcp", Port: 80, }}, + Type: api.ServiceTypeExternalName, }, }, } @@ -144,6 +145,7 @@ func (APIConnServiceTest) ServiceList() []*api.Service { Protocol: "tcp", Port: 80, }}, + Type: api.ServiceTypeExternalName, }, }, }