TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

plugin/cache: Add refresh mode setting to serve_stale (#5131)

Browse source 
This PR adds an optional REFRESH_MODE parameter on the serve_stale configuration directive of the
cache plugin, which verifies that the upstream is still unavailable before returning stale entries.

Signed-off-by: Antoine Tollenaere <atollena@gmail.com>
This commit is contained in:
Antoine Tollenaere 2022-05-02 19:16:33 +02:00 • committed by GitHub
parent c3572fdb30
commit 66f2ac7568
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 170 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

29
plugin/cache/setup_test.go vendored
View file

@ -117,20 +117,25 @@ func TestSetup(t *testing.T) {
func TestServeStale(t *testing.T) {
tests := []struct {
input string
shouldErr bool
staleUpTo time.Duration
input string
shouldErr bool
staleUpTo time.Duration
verifyStale bool
}{
{"serve_stale", false, 1 * time.Hour},
{"serve_stale 20m", false, 20 * time.Minute},
{"serve_stale 1h20m", false, 80 * time.Minute},
{"serve_stale 0m", false, 0},
{"serve_stale 0", false, 0},
{"serve_stale", false, 1 * time.Hour, false},
{"serve_stale 20m", false, 20 * time.Minute, false},
{"serve_stale 1h20m", false, 80 * time.Minute, false},
{"serve_stale 0m", false, 0, false},
{"serve_stale 0", false, 0, false},
{"serve_stale 0 verify", false, 0, true},
{"serve_stale 0 immediate", false, 0, false},
{"serve_stale 0 VERIFY", false, 0, true},
// fails
{"serve_stale 20", true, 0},
{"serve_stale -20m", true, 0},
{"serve_stale aa", true, 0},
{"serve_stale 1m nono", true, 0},
{"serve_stale 20", true, 0, false},
{"serve_stale -20m", true, 0, false},
{"serve_stale aa", true, 0, false},
{"serve_stale 1m nono", true, 0, false},
{"serve_stale 0 after nono", true, 0, false},
}
for i, test := range tests {
c := caddy.NewTestController("dns", fmt.Sprintf("cache {\n%s\n}", test.input))