TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

skip pushing watch updates when there are no watches (#2513)

Browse source
This commit is contained in:
Chris O'Haver 2019-01-29 14:15:49 -05:00 • committed by John Belamaric
parent 0eff7f3797
commit 68e09f00a4
1 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
plugin/kubernetes/watch.go
View file

@ -96,10 +96,16 @@ func (dns *dnsControl) sendUpdates(oldObj, newObj interface{}) {
switch ob := obj.(type) { switch ob := obj.(type) {
case *object.Service: case *object.Service:
dns.updateModifed() dns.updateModifed()
if len(dns.watched) == 0 {
return
}
dns.sendServiceUpdates(ob) dns.sendServiceUpdates(ob)
case *object.Endpoints: case *object.Endpoints:
if newObj == nil || oldObj == nil { if newObj == nil || oldObj == nil {
dns.updateModifed() dns.updateModifed()
if len(dns.watched) == 0 {
return
}
dns.sendEndpointsUpdates(ob) dns.sendEndpointsUpdates(ob)
return return
} }
@ -109,9 +115,15 @@ func (dns *dnsControl) sendUpdates(oldObj, newObj interface{}) {
return return
} }
dns.updateModifed() dns.updateModifed()
if len(dns.watched) == 0 {
return
}
dns.sendEndpointsUpdates(endpointsSubsetDiffs(p, ob)) dns.sendEndpointsUpdates(endpointsSubsetDiffs(p, ob))
case *object.Pod: case *object.Pod:
dns.updateModifed() dns.updateModifed()
if len(dns.watched) == 0 {
return
}
dns.sendPodUpdates(ob) dns.sendPodUpdates(ob)
default: default:
log.Warningf("Updates for %T not supported.", ob) log.Warningf("Updates for %T not supported.", ob)