TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

refactor tests to remove duplicate code (#2602)

Browse source 
Signed-off-by: darshanime <deathbullet@gmail.com>
This commit is contained in:
Darshan Chaudhary 2019-02-23 22:32:58 +05:30 • committed by Yong Tang
parent 92b7136684
commit 70fcbbf6ba
1 changed files with 39 additions and 81 deletions
Download patch file Download diff file Expand all files Collapse all files

118
plugin/route53/setup_test.go
View file

@ -13,106 +13,64 @@ func TestSetupRoute53(t *testing.T) {
return fakeRoute53{} return fakeRoute53{}
} }
c := caddy.NewTestController("dns", `route53`) tests := []struct {
if err := setup(c, f); err != nil { body string
t.Fatalf("Expected no errors, but got: %v", err) expectedError bool
} }{
{`route53`, false},
c = caddy.NewTestController("dns", `route53 :`) {`route53 :`, true},
if err := setup(c, f); err == nil { {`route53 example.org:12345678`, false},
t.Fatalf("Expected errors, but got: %v", err) {`route53 example.org:12345678 {
}
c = caddy.NewTestController("dns", `route53 example.org:12345678`)
if err := setup(c, f); err != nil {
t.Fatalf("Expected no errors, but got: %v", err)
}
c = caddy.NewTestController("dns", `route53 example.org:12345678 {
aws_access_key aws_access_key
}`) }`, true},
if err := setup(c, f); err == nil { {`route53 example.org:12345678 {
t.Fatalf("Expected errors, but got: %v", err)
}
c = caddy.NewTestController("dns", `route53 example.org:12345678 {
upstream 10.0.0.1 upstream 10.0.0.1
}`) }`, false},
if err := setup(c, f); err != nil {
t.Fatalf("Expected no errors, but got: %v", err)
}
c = caddy.NewTestController("dns", `route53 example.org:12345678 { {`route53 example.org:12345678 {
upstream upstream
}`) }`, false},
if err := setup(c, f); err != nil { {`route53 example.org:12345678 {
t.Fatalf("Expected no errors, but got: %v", err)
}
c = caddy.NewTestController("dns", `route53 example.org:12345678 {
wat wat
}`) }`, true},
if err := setup(c, f); err == nil { {`route53 example.org:12345678 {
t.Fatalf("Expected errors, but got: %v", err)
}
c = caddy.NewTestController("dns", `route53 example.org:12345678 {
aws_access_key ACCESS_KEY_ID SEKRIT_ACCESS_KEY aws_access_key ACCESS_KEY_ID SEKRIT_ACCESS_KEY
upstream 1.2.3.4 upstream 1.2.3.4
}`) }`, false},
if err := setup(c, f); err != nil {
t.Fatalf("Unexpected errors: %v", err)
}
c = caddy.NewTestController("dns", `route53 example.org:12345678 { {`route53 example.org:12345678 {
fallthrough fallthrough
}`) }`, false},
if err := setup(c, f); err != nil { {`route53 example.org:12345678 {
t.Fatalf("Unexpected errors: %v", err)
}
c = caddy.NewTestController("dns", `route53 example.org:12345678 {
credentials credentials
upstream 1.2.3.4 upstream 1.2.3.4
}`) }`, true},
if err := setup(c, f); err == nil {
t.Fatalf("Expected errors, but got: %v", err)
}
c = caddy.NewTestController("dns", `route53 example.org:12345678 { {`route53 example.org:12345678 {
credentials default credentials default
upstream 1.2.3.4 upstream 1.2.3.4
}`) }`, false},
if err := setup(c, f); err != nil { {`route53 example.org:12345678 {
t.Fatalf("Unexpected errors: %v", err)
}
c = caddy.NewTestController("dns", `route53 example.org:12345678 {
credentials default credentials credentials default credentials
upstream 1.2.3.4 upstream 1.2.3.4
}`) }`, false},
if err := setup(c, f); err != nil { {`route53 example.org:12345678 {
t.Fatalf("Unexpected errors: %v", err)
}
c = caddy.NewTestController("dns", `route53 example.org:12345678 {
credentials default credentials extra-arg credentials default credentials extra-arg
upstream 1.2.3.4 upstream 1.2.3.4
}`) }`, true},
if err := setup(c, f); err == nil { {`route53 example.org:12345678 example.org:12345678 {
t.Fatalf("Expected errors, but got: %v", err) upstream 1.2.3.4
}`, true},
{`route53 example.org {
upstream 1.2.3.4
}`, true},
} }
c = caddy.NewTestController("dns", `route53 example.org:12345678 example.org:12345678 { for _, test := range tests {
upstream 1.2.3.4 c := caddy.NewTestController("dns", test.body)
}`) if err := setup(c, f); (err == nil) == test.expectedError {
if err := setup(c, f); err == nil { t.Errorf("Unexpected errors: %v", err)
t.Fatalf("Expected errors, but got: %v", err)
} }
c = caddy.NewTestController("dns", `route53 example.org {
upstream 1.2.3.4
}`)
if err := setup(c, f); err == nil {
t.Fatalf("Expected errors, but got: %v", err)
} }
} }